Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ASTProvider to getAST for source action handlers #1533

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Use ASTProvider to getAST for source action handlers #1533

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f0908a
Use ASTProvider to getAST for source action handlers
testforstephen Aug 26, 2020
242c526
Address review comments
testforstephen Aug 26, 2020
274346c
Fix the test failure
testforstephen Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix the test failure 
Signed-off-by: Jinbo Wang <[email protected]>
  • Loading branch information
@testforstephen
testforstephen committed Aug 27, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 274346c4e98ba8589a159a1435ca06137bbb68b5
2 changes: 1 addition & 1 deletion ...se.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/GenerateToStringHandler.java
View file
Original file line number Diff line number Diff line change
@@ -121,7 +121,7 @@ public static TextEdit generateToString(IType type, LspVariableBinding[] fields,

// For test purpose
public static TextEdit generateToString(IType type, LspVariableBinding[] fields, ToStringGenerationSettingsCore settings) {
return generateToString(type, fields, new NullProgressMonitor());
return generateToString(type, fields, settings, new NullProgressMonitor());
}

public static TextEdit generateToString(IType type, LspVariableBinding[] fields, ToStringGenerationSettingsCore settings, IProgressMonitor monitor) {