Fix failed to find root path when workspace changes #1689
Conversation
Signed-off-by: Sheng Chen <[email protected]>
|
test this please |
|
Related issue - #1684 |
|
test this please |
| @@ -47,11 +47,12 @@ public void preferencesChange(Preferences oldPreferences, Preferences newPrefere | |||
|
|
|||
| try { | |||
| IFolder workspaceLinkFolder = javaProject.getProject().getFolder(ProjectUtils.WORKSPACE_LINK); | |||
| if (!workspaceLinkFolder.exists()) { | |||
| IPath rootPath = ProjectUtils.findBelongedWorkspaceRoot(workspaceLinkFolder.getLocation()); | |||
There was a problem hiding this comment.
if workspaceLinkFolder does not exist, what is returned by workspaceLinkFolder.getLocation()?
There was a problem hiding this comment.
It depends.
If it's the linked folder of an invisible project, it will return the linked folder path. If it's a visible project, it just appends _, for example: D:/Workspace/spring-petclinic/_
Why .exists() does not work is that, it just check if the handle of the resource exists, not check the real one. Below is part of the document copied from .exists():
IResource objects are lightweight handle objects used to access resources in the workspace. However, having a handle object does not necessarily mean the workspace really has such a resource.
Fix a regression bug introduced in #1658
When debugging Java Language Server, and the workspace changed, a error message pops as below:
This is because some stale elements remains in the JDT workspace.
Signed-off-by: Sheng Chen [email protected]