Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the supported features list in README #1703

Merged
merged 4 commits into from
Mar 26, 2021
Merged

Update the supported features list in README #1703

merged 4 commits into from
Mar 26, 2021

Conversation

testforstephen
Copy link
Contributor

No description provided.

testforstephen
testforstephen commented Mar 24, 2021
View reviewed changes
README.md
@@ -13,21 +13,28 @@ and can be used with any editor that supports the protocol, to offer good suppor

Features
--------------
* As you type reporting of parsing and compilation errors
* Supports compiling projects from Java 1.5 through 15
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we hold off Java 16 support in 1.0 release, i don't put 16 support to the features list yet.

@testforstephen testforstephen mentioned this pull request Mar 24, 2021
Closed
@rgrunber
Copy link
Contributor

rgrunber commented Mar 24, 2021 •
edited
Loading

Overall, I think this is good. Just a few things to maybe consider mentioning from looking through the CHANGELOG from the past little while :

  • enhancement - Provide method for converting callstack entry to location. See JLS#1202. (maybe? seems a bit too specific and not high-level enough, but maybe people disagree)
  • enhancement - Download sources for classes in jars with maven coordinates. See #1664. (likely should)
  • enhancement - Recommend dependency analytics extension. See #1771. (optional for pom.xml, maybe?)

@fbricon
Copy link
Contributor

fbricon commented Mar 24, 2021

dependency analytics extension recommendation is for vscode, irrelevant to jdt.ls

@testforstephen
Copy link
Contributor Author

enhancement - Provide method for converting callstack entry to location. See JLS#1202. (maybe? seems a bit too specific and not high-level enough, but maybe people disagree)

This is more like an API, not a specific feature. I prefer to not put it in this section.

@rgrunber
Copy link
Contributor

rgrunber commented Mar 25, 2021 •
edited
Loading

Let me know your thoughts on adding something like "Automatic source resolution for maven artifacts". If not, feel free to merge this.

jdneo
jdneo reviewed Mar 26, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@testforstephen
Copy link
Contributor Author

Let me know your thoughts on adding something like "Automatic source resolution for maven artifacts".

Agree, i have updated it to the features paragraph.

fbricon
fbricon reviewed Mar 26, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
rgrunber
rgrunber approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@rgrunber rgrunber merged commit fe1464c into eclipse-jdtls:master Mar 26, 2021
@testforstephen testforstephen deleted the jinbo_doc branch March 26, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo left review comments

@fbricon fbricon fbricon left review comments

@rgrunber rgrunber rgrunber approved these changes

@snjeza snjeza snjeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@testforstephen @rgrunber @fbricon @snjeza @jdneo