fix: Changes on Formatter profiles have no effect before reloading #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shi Chen <[email protected]>
snjeza
reviewed
Apr 22, 2021
| @@ -193,7 +194,12 @@ public void fileChanged(String uriString, CHANGE_TYPE changeType) { | |||
| List<URI> uris = getURIs(formatterUrl); | |||
| boolean changed = false; | |||
| for (URI formatterUri : uris) { | |||
| if (formatterUri.equals(uri)) { | |||
| if (Platform.OS_WIN32.equals(Platform.getOS()) && URIUtil.isFileURI(formatterUri) && URIUtil.isFileURI(uri)) { | |||
There was a problem hiding this comment.
Could you add similar code for the settingsUri variable - 008b542#diff-f23d0258ce24117c110acd6753e8490a09fbdf0bc039d662bdffe279c8c28469L177 ?
Signed-off-by: Shi Chen <[email protected]>
| @@ -175,7 +176,12 @@ public void fileChanged(String uriString, CHANGE_TYPE changeType) { | |||
| List<URI> uris = getURIs(settingsUrl); | |||
| boolean changed = false; | |||
| for (URI settingsURI : uris) { | |||
| if (settingsURI.equals(uri)) { | |||
| if (Platform.OS_WIN32.equals(Platform.getOS()) && URIUtil.isFileURI(settingsURI) && URIUtil.isFileURI(uri)) { | |||
There was a problem hiding this comment.
this could be a helper method compareURI(URI uri1, URI uri2).
There was a problem hiding this comment.
Should this util be put into JDTUtils?
There was a problem hiding this comment.
org.eclipse.core.runtime.URIUtil#sameURI seems to do the same thing you want. Could you check if that satisfies your needs?
There was a problem hiding this comment.
It works. I'll use it then.
Signed-off-by: Shi Chen <[email protected]>
|
test this please |
1 similar comment
|
test this please |
testforstephen
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1736
Signed-off-by: Shi Chen [email protected]