Add Getter and Setter to Show Fixes for type declaration #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shi Chen <[email protected]>
Signed-off-by: Shi Chen <[email protected]>
| Optional<Either<Command, CodeAction>> getterSetter = getGetterSetterAction(params, context, type); | ||
| addSourceActionCommand($, params.getContext(), getterSetter); | ||
| // Generate Getter and Setter QuickAssist | ||
| if (isInTypeDeclaration(context)) { |
There was a problem hiding this comment.
isInTypeDeclaration(context) is called multiple times in source action handler, you can assign it to a local variable boolean isInTypeDeclaration = isInTypeDeclaration(context); for reuse.
Comment on lines
282
to
288
| ASTNode declarationNode = null; | ||
| CompilationUnit astRoot = CoreASTProvider.getInstance().getAST(type.getCompilationUnit(), CoreASTProvider.WAIT_YES, monitor); | ||
| Range range = params.getRange(); | ||
| if (astRoot != null && range != null) { | ||
| ASTNode node = NodeFinder.perform(astRoot, DiagnosticsHelper.getStartOffset(type.getCompilationUnit(), range), DiagnosticsHelper.getLength(type.getCompilationUnit(), range)); | ||
| declarationNode = SourceAssistProcessor.getDeclarationNode(node); | ||
| } |
There was a problem hiding this comment.
This block of code is used to check if the cursor is in a position of type declaration. Since the external invoker has already checked the cursor position, why not to pass it to getGetterSetterAction function directly?
Signed-off-by: Shi Chen <[email protected]>
| @@ -37,6 +37,7 @@ | |||
| import org.eclipse.jdt.core.dom.BodyDeclaration; | |||
| import org.eclipse.jdt.core.dom.CompilationUnit; | |||
| import org.eclipse.jdt.core.dom.ITypeBinding; | |||
| import org.eclipse.jdt.core.dom.NodeFinder; | |||
| @@ -74,6 +75,7 @@ | |||
| import org.eclipse.lsp4j.CodeActionKind; | |||
| import org.eclipse.lsp4j.CodeActionParams; | |||
| import org.eclipse.lsp4j.Command; | |||
| import org.eclipse.lsp4j.Range; | |||
| codeActions = server.codeAction(params).join(); | ||
| Assert.assertNotNull(codeActions); | ||
| quickAssistActions = CodeActionHandlerTest.findActions(codeActions, JavaCodeActionKind.QUICK_ASSIST); | ||
| Assert.assertFalse(quickAssistActions.isEmpty()); |
There was a problem hiding this comment.
this assert is not relevant with this test case. You could remove it.
Signed-off-by: Shi Chen <[email protected]>
testforstephen
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of redhat-developer/vscode-java#2057
And a follow of redhat-developer/vscode-java#2057 (comment), IMO it's better to make all the QuickPick items (for generating getter and setter) picked by default. Does it make sense?
cc: @nickzhums, @testforstephen
Signed-off-by: Shi Chen [email protected]