Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract lambda body to method #2044

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Apr 1, 2022

Fixes #2027

Signed-off-by: Snjezana Peco [email protected]

Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is working pretty well for me.

Signed-off-by: Snjezana Peco <[email protected]>
@snjeza
Copy link
Contributor Author

snjeza commented Apr 7, 2022

@rgrunber I have updated the PR.

Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe I can nudge upstream to fix the same issue with "extracted" uniqueness checking.

@rgrunber rgrunber merged commit a60432d into eclipse-jdtls:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract lambda body to method
2 participants