Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error status when the project is not created #2059

Merged
merged 3 commits into from
May 4, 2022

Conversation

CsCherrYY
Copy link
Contributor

fix #2058

In some cases when importing is failed, the buildship will not create the corresponding IProject so that ProjectUtils.getAllProjects() will not list all the projects in the workspace, even though some build file in those projects has markers created.

Signed-off-by: Shi Chen [email protected]

@CsCherrYY
Copy link
Contributor Author

test this please

Signed-off-by: Shi Chen <[email protected]>
Copy link
Contributor

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. It will show error marker in the status bar now. While the current marketplace version shows a 👍

@rgrunber rgrunber modified the milestone: Early May 2022 May 3, 2022
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Just squash into one commit and feel free to rebase+merge.

@testforstephen testforstephen merged commit c64c32c into eclipse-jdtls:master May 4, 2022
@rgrunber rgrunber removed this from the Early May 2022 milestone May 4, 2022
@CsCherrYY CsCherrYY deleted the cs-status branch May 5, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error status won't show when there is an error in subprojects
4 participants