Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate all open buffers on changes #288

Merged

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Jul 4, 2017

Fixes #279

#279 is about a code action that modify an different file. If 'autoSave' is disabled, both buffers will be dirty after applying the fix.
JDT.LS currently only validates saved files and modified buffers.

This PR is about verifying all open buffers when a buffer changes.

  • contains fixes so that cu.hsUnsavedChanges works correctly
  • contains changes to compute multiple AST using the AST requester, reusing already computed bindings
  • makes sure the SharedASTProvider only holds on the CU's in working copy mode

@fbricon fbricon added this to the End July 2017 milestone Jul 4, 2017
@fbricon fbricon self-requested a review July 4, 2017 14:22
@fbricon fbricon merged commit 2dd88b8 into eclipse-jdtls:master Jul 4, 2017
@patilarpith
Copy link

Is there a configuration to disable validation of all open buffers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code actions modifying other files don't update current file diagnostics
4 participants