Log and continue when the importer scanner encounters a directory that is inaccessible or does not exist #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is inaccessible or does not exist Signed-off-by: Jinbo Wang <[email protected]>
rgrunber
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Change seems fine and reduces the volume of errors in the logs.
I was able to reproduce by just restricting permissions on a folder (eg. .vscode/ ) . I expected this change to leave the language support in a broken state but everything seemed to work despite the project import failing. Any ideas why ? Update: I'm wrong, the project import definitely broke certain things like searching into libraries, and go-to-definition.
Feel free to merge once the error message is updated.
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/BasicFileDetector.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#3137
Fixes redhat-developer/vscode-java#1156
Fixes #2855