Add methods,inherited fields,inherited methods to Generate toString() #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
reviewed
Feb 28, 2024
...lipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/GenerateToStringHandler.java
Outdated
Show resolved
Hide resolved
|
@rgrunber I have updated the PR. |
rgrunber
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Overall, I think the code is good to merge. Just one thing I noticed.
toStringsupport for records doesn't really suggest the record components. Upstream does it with https://github.com/eclipse-jdt/eclipse.jdt.ui/blob/30c501df8780ac9a6f043b35ff17ad9f4211d611/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/GenerateToStringAction.java#L208-L214. Our entry point would be at .
Can this be done in this PR or is there more involved ?
Signed-off-by: Snjezana Peco <[email protected]>
|
@rgrunber I have updated the PR. |
rgrunber
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Note that this still doesn't fix the issue for records. It'll generate a toString as before, with no dialog to allow the user to select members to be included. If you look at
nonStaticFields is false and isInTypeDeclaration is also false. The result is just a source action being generated with an empty ( LSPVariableBinding[0] ) selection.
However, I noticed that hasFields is also called for constructor generation, so I'm fine with addressing this in some other PR since it seems to drag in that logic also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#2639
Requires redhat-developer/vscode-java#3495