Add 'final' to 'Extract to local variable' result if requested #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Looks pretty good overall. I would rename the commit to :
Add 'final' to 'Extract to local variable' result if requested.
- 'Extract to local variable' / 'Extract to local variable (replace all occurrences)' will respect
java.codeGeneration.addFinalForNewDeclaration
...dt.ls.tests/src/org/eclipse/jdt/ls/core/internal/refactoring/GetRefactorEditHandlerTest.java
Outdated
Show resolved
Hide resolved
hopehadfield
force-pushed
the
3308-extract-local-var
branch
from
ec32754 to
1a84f2b
Compare
hopehadfield
changed the title
rgrunber
reviewed
Jun 20, 2024
...dt.ls.core/src/org/eclipse/jdt/ls/core/internal/text/correction/RefactorProposalUtility.java
Outdated
Show resolved
Hide resolved
rgrunber
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Just need to address that comment I made about shortening the setFinal logic. Then we can merge.
I was considering ExtractFieldRefactoring as well, but a final field that isn't also static might be a more rare case.
Also, if you could adjust the body of the commit message so the line is longer than 80 characters. Update: Not longer..
- 'Extract to local variable' / 'Extract to local variable (replace all occurrences)' will respect 'java.codeGeneration.addFinalForNewDeclaration' Signed-off-by: Hope Hadfield <[email protected]>
hopehadfield
force-pushed
the
3308-extract-local-var
branch
from
1a84f2b to
b0cd695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies when the
java.codeGeneration.addFinalForNewDeclarationsetting is set toallorvariables. Also applicable for the 'replace all occurrences' extract proposal.Closes redhat-developer/vscode-java#3308