Import Gradle project via Buildship if Gradle Build Server is not available #3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It works fine for me. Nature ids are always hard coded. Could you, please, add a test? |
Thank you! if it looks fine, I'll continue the work. |
- Due to the build server has a higher priority, if the Buildship kicks in during import. This mean build server fails to import the projects and Buildship will be used and the footprint of the build server will be removed if exists. Signed-off-by: Sheng Chen <[email protected]>
jdneo
force-pushed
the
cs/gradle-remove
branch
from
176d9a4 to
e9ec0a9
Compare
Signed-off-by: Sheng Chen <[email protected]>
|
test this please |
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There will be the case when user has imported the gradle project by build server. Then, the user disable/uninstall the gradle extension.
In this case, the build server project should not be excluded when gradle importer scans the folder to import.
But, so far I cannot figure out a perfect way to do that. The nature id for build server is hard coded. @snjeza @rgrunber Do you know if we can have better approach than this?