Autocompletion overwrites following characters #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
reviewed
Nov 1, 2017
| @@ -475,6 +476,13 @@ public void didOpen(DidOpenTextDocumentParams params) { | |||
| @Override | |||
| public void didChange(DidChangeTextDocumentParams params) { | |||
| logInfo(">> document/didChange"); | |||
| try { | |||
| Job.getJobManager().join(DocumentLifeCycleHandler.DOCUMENT_LIFE_CYCLE_JOBS, new NullProgressMonitor()); | |||
There was a problem hiding this comment.
While the fix works as expected, I'm a bit worried about joining on a job without possibilities to cancel. Are there any other alternatives?
snjeza
force-pushed
the
issue-352
branch
2 times, most recently
from
6193c05 to
43a6afa
Compare
fbricon
reviewed
Nov 1, 2017
| jobs = Job.getJobManager().find(DocumentLifeCycleHandler.DOCUMENT_LIFE_CYCLE_JOBS); | ||
| wait = (System.currentTimeMillis() - start) < 5000 && jobs.length > 0; | ||
| if (wait) { | ||
| Thread.sleep(400); |
There was a problem hiding this comment.
sleep 100ms
And we should probably move that piece of code to the JobHelper, which itself needs to move from tests to core.
|
This change completely kills autocompletion, we need to find something else. |
snjeza
force-pushed
the
issue-352
branch
2 times, most recently
from
24e9c2c to
932e948
Compare
Signed-off-by: Snjezana Peco <[email protected]>
fbricon
approved these changes
Nov 1, 2017
tsmaeder
reviewed
Nov 2, 2017
| } catch (OperationCanceledException ignorable) { | ||
| // No need to pollute logs when query is cancelled | ||
| } catch (InterruptedException e) { | ||
| JavaLanguageServerPlugin.logException(e.getMessage(), e); |
There was a problem hiding this comment.
Don't forget the Thread.currentThread().interrupt();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#352
Signed-off-by: Snjezana Peco [email protected]