Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java.import.exclusions preference is ignored during server startup #560

Closed
wants to merge 1 commit into from
Closed

java.import.exclusions preference is ignored during server startup #560

wants to merge 1 commit into from

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Feb 20, 2018 •
edited by fbricon
Loading

@snjeza snjeza requested review from gorkem and fbricon February 20, 2018 18:09
@snjeza snjeza mentioned this pull request Feb 20, 2018
Closed
fbricon
fbricon reviewed Feb 20, 2018
View reviewed changes
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/InitHandler.java Outdated
@@ -108,6 +110,10 @@ InitializeResult initialize(InitializeParams param) {
logInfo("No workspace folders or root uri was defined. Falling back on " + workspaceLocation);
rootPaths.add(workspaceLocation);
}
List<String> javaImportExclusions = getJavaImportExclusions(initializationOptions);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than cherry-picking the prefs we need during initialization, can't we just get the whole deal instead? We could instantiate a Preference object out of initializationOptions

@snjeza
Copy link
Contributor Author

snjeza commented Feb 20, 2018

@fbricon I have updated the PR.

@fbricon
Copy link
Contributor

fbricon commented Feb 21, 2018

@snjeza I merged the original PR as e4ffa92, as expecting a settings map similar to the one in workspace/didChangeConfiguration is more consistent.

@fbricon fbricon closed this Feb 21, 2018
@snjeza
Copy link
Contributor Author

snjeza commented Feb 21, 2018

I merged the original PR as e4ffa92, as expecting a settings map similar to the one in workspace/didChangeConfiguration is more consistent.

ok.

@snjeza snjeza deleted the issue-444 branch February 21, 2018 00:19
@SreenivasVRao SreenivasVRao mentioned this pull request Jul 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon left review comments

@gorkem gorkem Awaiting requested review from gorkem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snjeza @fbricon