interface/class snippets should not be available inside method bodies #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please |
|
test this please |
fbricon
reviewed
Jun 12, 2018
| //This check might need to be pushed back to the different get*Snippet() methods, depending on future features | ||
| if (UNSUPPORTED_RESOURCES.contains(cu.getResource().getName())) { | ||
| return Collections.emptyList(); | ||
| } | ||
| if (!accept(cu, completionContext, true)) { |
There was a problem hiding this comment.
L65-L70 need to be moved inside getClassSnippet.
if accept returns false, then you're not even trying interfaces next
fbricon
reviewed
Jun 12, 2018
| if (classSnippet != null) { | ||
| res.add(classSnippet); | ||
| } | ||
| CompletionItem interfaceSnippet = getInterfaceSnippet(cu); | ||
| if (!accept(cu, completionContext, false)) { |
There was a problem hiding this comment.
L80-L85 need to be moved to getInterfaceSnippet
fbricon
reviewed
Jun 12, 2018
| @@ -109,6 +108,7 @@ public boolean isCanceled() { | |||
| try { | |||
| unit.codeComplete(offset, collector, subMonitor); | |||
| proposals.addAll(collector.getCompletionItems()); | |||
| proposals.addAll(SnippetCompletionProposal.getSnippets(unit, collector.getContext(), subMonitor)); | |||
There was a problem hiding this comment.
the problem here is the proposals ignore the currently typed text, i.e if you type m in the class body, you'd still get the class and interface snippets proposals. While vscode luckily filters them out, other clients won't necessarily do it.
Signed-off-by: Snjezana Peco <[email protected]>
|
@fbricon I have updated the PR. |
|
Thanks @snjeza! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #681
I have removed the class/interface snippets from the following contexts:
The class snippets is sometimes allowed in the method body such as:
I have also changed the snippets to not generate duplicated public keywords, as in the following place:
BTW all the client snippets have the same issue.
Signed-off-by: Snjezana Peco [email protected]