Lower severity of m2e's 'Project configuration is not up-to-date...' diagnostics #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
reviewed
Aug 28, 2018
| String message = marker.getAttribute(IMarker.MESSAGE, ""); | ||
| if (message != null && message.startsWith("Project configuration is not up-to-date with pom.xml.")) { | ||
| message = "Project configuration is not up-to-date with pom.xml, requires an update."; | ||
| d.setSeverity(DiagnosticSeverity.Warning); |
There was a problem hiding this comment.
No the severity change should be at the m2e preferences level, or else the build command will continue to fail if such an error is reported. See microsoft/vscode-java-debug#358
There was a problem hiding this comment.
I have updated the PR.
fbricon
reviewed
Aug 29, 2018
| @@ -148,6 +151,12 @@ public void start(BundleContext bundleContext) throws Exception { | |||
| contentProviderManager = new ContentProviderManager(preferenceManager); | |||
| logInfo(getClass() + " is started"); | |||
| configureProxy(); | |||
| configureMavenPreferences(); | |||
There was a problem hiding this comment.
should be moved to the preferences manager
There was a problem hiding this comment.
initializeJDTOptions should be removed BTW, since it's covered by PreferenceManager.initialize()
fbricon
reviewed
Aug 29, 2018
| configureMavenPreferences(); | ||
| } | ||
|
|
||
| private void configureMavenPreferences() { |
…diagnostics Signed-off-by: Snjezana Peco <[email protected]>
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #763
Signed-off-by: Snjezana Peco [email protected]