Add hover for package fragments #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Thomann <[email protected]>
fbricon
reviewed
Oct 7, 2016
| // We need to select the one that matches the package fragment of the current unit | ||
| IJavaElement found = null; | ||
| IPackageFragment packageFragment = (IPackageFragment) unit.getParent(); | ||
| loop: for (IJavaElement element : elements) { |
There was a problem hiding this comment.
Stream.of(elements)
.filter(e -> e.equals(packageFragment))
.findFirst().orElse(null);
gorkem
reviewed
Oct 7, 2016
Signed-off-by: Olivier Thomann <[email protected]>
yaohaizh
pushed a commit
to yaohaizh/eclipse.jdt.ls
that referenced
this pull request
Jul 4, 2017
Signed-off-by: Fred Bricon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose these changes to add some hover contents for a package fragment. This should work for the actual package declaration of the current unit if there is a package-info.java file in the same package or for import statements when you hover on the package part of the import.
Let me know what you think.