Migrate to Buildship 3.0 #876

snjeza · 2018-12-01T20:41:50Z

Fixes #875

Signed-off-by: Snjezana Peco [email protected]

snjeza · 2018-12-01T21:31:18Z

test this please

fbricon · 2018-12-03T14:23:33Z

Tried importing https://github.com/spring-projects/spring-amqp, failed with:

[Warn  - 9:20:49 AM] 3-Dec-2018 9:20:49 AM Synchronize project spring-amqp failed due to an error while importing the root project.
java.lang.NullPointerException
org.eclipse.buildship.core.internal.ImportRootProjectException: java.lang.NullPointerException
	at org.eclipse.buildship.core.internal.workspace.ImportRootProjectOperation.run(ImportRootProjectOperation.java:52)
	at org.eclipse.buildship.core.internal.DefaultGradleBuild$SynchronizeOperation.runInToolingApi(DefaultGradleBuild.java:216)
	at org.eclipse.buildship.core.internal.operation.DefaultToolingApiOperationManager$WorkspaceRunnableAdapter.run(DefaultToolingApiOperationManager.java:57)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2295)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2322)
	at org.eclipse.buildship.core.internal.operation.DefaultToolingApiOperationManager.run(DefaultToolingApiOperationManager.java:38)
	at org.eclipse.buildship.core.internal.DefaultGradleBuild$SynchronizeOperation.run(DefaultGradleBuild.java:182)
	at org.eclipse.buildship.core.internal.DefaultGradleBuild.synchronize(DefaultGradleBuild.java:95)
	at org.eclipse.buildship.core.internal.DefaultGradleBuild.synchronize(DefaultGradleBuild.java:81)
	at org.eclipse.jdt.ls.core.internal.managers.GradleProjectImporter.startSynchronization(GradleProjectImporter.java:149)
	at org.eclipse.jdt.ls.core.internal.managers.GradleProjectImporter.importDir(GradleProjectImporter.java:94)
	at org.eclipse.jdt.ls.core.internal.managers.GradleProjectImporter.lambda$0(GradleProjectImporter.java:86)
	at java.util.ArrayList.forEach(ArrayList.java:1249)
	at java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1080)
	at org.eclipse.jdt.ls.core.internal.managers.GradleProjectImporter.importToWorkspace(GradleProjectImporter.java:86)
	at org.eclipse.jdt.ls.core.internal.managers.ProjectsManager.importProjects(ProjectsManager.java:134)
	at org.eclipse.jdt.ls.core.internal.managers.ProjectsManager.access$1(ProjectsManager.java:128)
	at org.eclipse.jdt.ls.core.internal.managers.ProjectsManager$2.run(ProjectsManager.java:122)
	at org.eclipse.jdt.internal.core.BatchOperation.executeOperation(BatchOperation.java:41)
	at org.eclipse.jdt.internal.core.JavaModelOperation.run(JavaModelOperation.java:736)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2295)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2322)
	at org.eclipse.jdt.core.JavaCore.run(JavaCore.java:5810)
	at org.eclipse.jdt.core.JavaCore.run(JavaCore.java:5767)
	at org.eclipse.jdt.ls.core.internal.managers.ProjectsManager.initializeProjects(ProjectsManager.java:114)
	at org.eclipse.jdt.ls.core.internal.handlers.InitHandler$1.runInWorkspace(InitHandler.java:229)
	at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:42)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Caused by: java.lang.NullPointerException
	at com.google.common.base.Joiner.join(Joiner.java:187)
	at org.eclipse.buildship.core.internal.configuration.BuildConfigurationPersistence.savePreferences(BuildConfigurationPersistence.java:163)
	at org.eclipse.buildship.core.internal.configuration.BuildConfigurationPersistence.saveBuildConfiguration(BuildConfigurationPersistence.java:71)
	at org.eclipse.buildship.core.internal.configuration.DefaultConfigurationManager.saveBuildConfiguration(DefaultConfigurationManager.java:99)
	at org.eclipse.buildship.core.internal.configuration.DefaultConfigurationManager.saveProjectConfiguration(DefaultConfigurationManager.java:136)
	at org.eclipse.buildship.core.internal.workspace.ImportRootProjectOperation.saveProjectConfiguration(ImportRootProjectOperation.java:82)
	at org.eclipse.buildship.core.internal.workspace.ImportRootProjectOperation.access$200(ImportRootProjectOperation.java:38)
	at org.eclipse.buildship.core.internal.workspace.ImportRootProjectOperation$1.run(ImportRootProjectOperation.java:67)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2295)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2317)
	at org.eclipse.buildship.core.internal.workspace.ImportRootProjectOperation.runInWorkspace(ImportRootProjectOperation.java:57)
	at org.eclipse.buildship.core.internal.workspace.ImportRootProjectOperation.run(ImportRootProjectOperation.java:50)
	... 27 more

snjeza · 2018-12-03T15:11:18Z

@fbricon re Buildship sources (eclipse-buildship/buildship#327)

You can try the following:

git clone [email protected]:eclipse/buildship.git
cd buildship
git checkout release-3.0
./gradlew build -x eclipseTest

import org.eclipse.builship.core (and org.eclipse.builship.ui) in Eclipse

fbricon · 2018-12-03T15:19:40Z

@snjeza I just cloned the repo and made eclipse point at the repo directory when searching for sources, it's simpler. But what would be even simpler is to have those sources available directly.

snjeza · 2018-12-03T15:22:07Z

test this please

fbricon · 2018-12-04T14:23:33Z

@snjeza can you reproduce the NPE above? I still have the same issue with the latest buildship build

fbricon · 2018-12-04T14:27:08Z

...eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/GradleProjectImporter.java

-			build.synchronize(NewProjectHandler.IMPORT_AND_MERGE);
+			String javaHomeStr = JavaLanguageServerPlugin.getPreferencesManager().getPreferences().getJavaHome();
+			File javaHome = javaHomeStr == null ? null : new File(javaHomeStr);
+			BuildConfiguration configuration = CorePlugin.configurationManager().createBuildConfiguration(location, overrideWorkspaceSettings, distribution, getGradleHomeFile(), javaHome, false, false, false, null, null, false, false);


avoid passing null objects to the configuration, this is the cause for the NPE. Try with empty lists.

Would it be possible for you to switch to the new public API?

BuildConfiguration build = BuildConfiguration.forRootProjectDirectory(new File("path/to/root")) .javaHome(new File("path/to/jdk")) .arguments(Arrays.asList("--info")) // ... .build(); SynchronizationResult result = GradleCore.getWorkspace().createBuild(build).synchronize(monitor); System.out.println(result.getStatus().isOK());

fbricon · 2018-12-04T14:49:54Z

@snjeza can you do a quick assessment of the extra disk space added to the distro if we threw in the gradle/kotlin bundles?

Signed-off-by: Snjezana Peco <[email protected]>

snjeza · 2018-12-04T19:19:36Z

@snjeza can you reproduce the NPE above? I still have the same issue with the latest buildship build

I can reproduce it when I set GRADLE_HOME

snjeza · 2018-12-04T20:18:00Z

@snjeza can you do a quick assessment of the extra disk space added to the distro if we threw in the gradle/kotlin bundles?

@fbricon Do you mean https://github.com/JetBrains/kotlin-eclipse?

fbricon · 2018-12-04T20:32:57Z

org.eclipse.buildship.kotlin and its dependencies, so yeah I imagine that includes some of jetbrains plugins

snjeza · 2018-12-04T21:17:24Z

org.eclipse.buildship.kotlin requires org.eclipse.jdt.ui - see https://github.com/eclipse/buildship/blob/master/org.eclipse.buildship.kotlin/META-INF/MANIFEST.MF#L18 and https://github.com/JetBrains/kotlin-eclipse/blob/master/kotlin-eclipse-core/META-INF/MANIFEST.MF#L27

fbricon · 2018-12-04T21:24:24Z

tssss. This is a no-go then. Can you please open a ticket in https://github.com/JetBrains/kotlin-eclipse/ so they decouple their core plugins from the ui?

Signed-off-by: Snjezana Peco <[email protected]>

snjeza · 2018-12-05T21:11:25Z

tssss. This is a no-go then. Can you please open a ticket in https://github.com/JetBrains/kotlin-eclipse/ so they decouple their core plugins from the ui?

I can't create any issues in https://github.com/JetBrains/kotlin-eclipse/

cheuk-fung · 2019-02-07T01:16:46Z

@snjeza @fbricon kotlin-eclipse does not track issue on Github. I've created one for this issue in their issue tracker: https://youtrack.jetbrains.com/issue/KE-307?project=KE&clearDraft=true
Hopefully this will help you continue to integrate buildship.kotlin and add support for Gradle Kotlin DSL.

snjeza requested review from gorkem and fbricon December 1, 2018 20:41

snjeza force-pushed the issue-875 branch from 75b9ad7 to 7e2abcf Compare December 2, 2018 16:00

fbricon mentioned this pull request Dec 3, 2018

Publish Buildship sources on update site eclipse-buildship/buildship#327

Closed

snjeza force-pushed the issue-875 branch from 7e2abcf to 5a0cdd6 Compare December 3, 2018 15:09

fbricon reviewed Dec 4, 2018

View reviewed changes

fbricon mentioned this pull request Dec 4, 2018

NPEs are thrown if DefaultBuildConfigurationProperties arguments and vmArguments are null eclipse-buildship/buildship#816

Closed

fbricon added enhancement gradle labels Dec 4, 2018

Migrate to Buildship 3.0

55af926

Signed-off-by: Snjezana Peco <[email protected]>

snjeza force-pushed the issue-875 branch from 5a0cdd6 to 55af926 Compare December 4, 2018 19:18

fixup! Migrate to Buildship 3.0

01509ed

Signed-off-by: Snjezana Peco <[email protected]>

fbricon merged commit a464abe into eclipse-jdtls:master Dec 4, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to Buildship 3.0 #876

Migrate to Buildship 3.0 #876

snjeza commented Dec 1, 2018

snjeza commented Dec 1, 2018

fbricon commented Dec 3, 2018

snjeza commented Dec 3, 2018

fbricon commented Dec 3, 2018

snjeza commented Dec 3, 2018

fbricon commented Dec 4, 2018

fbricon Dec 4, 2018

donat Dec 4, 2018

fbricon commented Dec 4, 2018

snjeza commented Dec 4, 2018

snjeza commented Dec 4, 2018

fbricon commented Dec 4, 2018

snjeza commented Dec 4, 2018

fbricon commented Dec 4, 2018

snjeza commented Dec 5, 2018

cheuk-fung commented Feb 7, 2019 •

edited

Loading

Migrate to Buildship 3.0 #876

Migrate to Buildship 3.0 #876

Conversation

snjeza commented Dec 1, 2018

snjeza commented Dec 1, 2018

fbricon commented Dec 3, 2018

snjeza commented Dec 3, 2018

fbricon commented Dec 3, 2018

snjeza commented Dec 3, 2018

fbricon commented Dec 4, 2018

fbricon Dec 4, 2018

Choose a reason for hiding this comment

donat Dec 4, 2018

Choose a reason for hiding this comment

fbricon commented Dec 4, 2018

snjeza commented Dec 4, 2018

snjeza commented Dec 4, 2018

fbricon commented Dec 4, 2018

snjeza commented Dec 4, 2018

fbricon commented Dec 4, 2018

snjeza commented Dec 5, 2018

cheuk-fung commented Feb 7, 2019 • edited Loading

cheuk-fung commented Feb 7, 2019 •

edited

Loading