Recognize new maven, gradle, eclipse project(s) after first init #901

snjeza · 2018-12-13T15:53:51Z

Fixes #144
Requires redhat-developer/vscode-java#746

Signed-off-by: Snjezana Peco [email protected]

fbricon · 2018-12-14T22:30:28Z

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/ProjectsManager.java

@@ -251,6 +251,9 @@ public void fileChanged(String uriString, CHANGE_TYPE changeType) {
 			return;
 		}
 		IResource resource = JDTUtils.isFolder(uriString) ? JDTUtils.findFolder(uriString) : JDTUtils.findFile(uriString);
+		if (resource == null && changeType == CHANGE_TYPE.CREATED) {


I believe it should be moved to the if (isBuildFile(..) block, L283

so this doesn't work if you want to create a new module within an existing maven structure

I believe it should be moved to the if (isBuildFile(..) block, L283

We will not come to L283 if a resource is null

fbricon · 2018-12-14T23:13:23Z

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/ProjectsManager.java

@@ -302,6 +305,26 @@ public void fileChanged(String uriString, CHANGE_TYPE changeType) {
 		}
 	}

+	private IResource refreshRootFolders(String uriString) {


I think automatic detection is probably not always safe (might break Che's use case, we'd need @tsmaeder, @svor or @tolusha 's feedback on that), or could be unreliable (here it doesn't detect a new pom under a parent project).
So at the very least, we should expose a new import command, users could call explicitly. che-jdt-ls might have something already they could contribute back.
If we do automatic project import, it should be enabled via a preference

snjeza · 2018-12-14T23:32:39Z

(here it doesn't detect a new pom under a parent project).

See https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/MavenBuildSupport.java#L106

So at the very least, we should expose a new import command, users could call explicitly.

Java: Refresh workspace?

If we do automatic project import, it should be enabled via a preference

'java.import.new.project.enabled', default: false ?

fbricon · 2018-12-15T00:10:31Z

(here it doesn't detect a new pom under a parent project).

See https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/MavenBuildSupport.java#L106

So at the very least, we should expose a new import command, users could call explicitly.

Java: Refresh workspace?

Java: detect and import Java projects

If we do automatic project import, it should be enabled via a preference

'java.import.new.project.enabled', default: false ?

java.import.newprojects: automatic/interactive/disabled

snjeza · 2018-12-15T19:53:02Z

@fbricon I have updated the PR.

fbricon · 2018-12-20T21:23:04Z

@tsmaeder @tolusha @svor we need your input please

fbricon · 2018-12-21T15:10:48Z

@snjeza please rebase against master

snjeza · 2018-12-21T18:14:03Z

@fbricon I have rebased the PR.

svor · 2018-12-22T11:54:21Z

@fbricon At this moment I can not test it on che side, we still depend on 0.5.0 version of lsp4j. So at first we need to solve eclipse-che/che#12262.

tsmaeder · 2019-03-18T13:21:36Z

We use a fixed version of jdt.ls in Che 6, so we should not be broken. Che 7 uses vscode-java anyway. So I think Che 6 should not block progress on this.

snjeza · 2019-07-09T15:52:36Z

I have updated the PR.
@fbricon @tsmaeder @tolusha @svor @l0rd could you, please, test it? You can use https://raw.githubusercontent.com/snjeza/vscode-test/master/java-0.47.0.vsix

I have tested in the following way:

build theia
add java-0.47.0.vsix to the <theia_root>/plugins directory
open an empty workspace
cd <workspace_root>
git clone [email protected]:spring-projects/spring-petclinic.git

You can also test in VS Code.

snjeza · 2020-01-26T17:12:04Z

test this please

fbricon · 2020-02-03T16:18:25Z

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/ProjectsManager.java

@@ -119,6 +119,13 @@
 		CREATED, CHANGED, DELETED
 	};

+	//@formatter:off
+	private static final List<String> buildFiles = Arrays.asList(


the list of interesting build files should be provided by each project importer instance, as to minimize coupling with build systems here

fbricon · 2020-02-03T16:21:36Z

...clipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/ImportNewProjectsTest.java

+ *
+ */
+@RunWith(MockitoJUnitRunner.class)
+public class ImportNewProjectsTest extends AbstractProjectsManagerBasedTest {


need to check a new build file added to a build directory of an existing project doesn't trigger project import (think test pom.xml processed during a build)

jdneo · 2020-03-11T07:46:19Z

@fbricon @snjeza

I noticed that it's mentioned to provide a new command to import the projects. This is exactly what we hope to add in VS Code Java.

May I ask will this command be added in this PR? If not, would you mind me to pick up this work item?

snjeza · 2020-03-11T15:45:40Z

I noticed that it's mentioned to provide a new command to import the projects. This is exactly what we hope to add in VS Code Java.

@jdneo See redhat-developer/vscode-java#746

jdneo · 2020-03-24T06:25:38Z

I'm thinking that do we need to add the configuration(java.import.newprojects) for auto import detection?

IMO, I think just providing the import command to the users will be enough. Since the configuration may confuse the users in the following scenarios:

When the configuration file is added in a deeper level (not the direct submodule of the root module), nothing will happen due to we are only detecting one level.
When the configuration file is added but empty. For example, after creating a new pom.xml, the user will get a notification: A new file was added. Do you want to import projects?, but there won't be any updates by selecting Now/Always, since the pom.xml is empty so actually the user still needs to invoke the command to import it after the content is completed.

jdneo · 2020-04-01T02:27:07Z

How is everything @snjeza 😃

Just would like to ask if you will continue working on this PR? And if you've already planned for other works, would you mind me to take over it?

Thanks.

snjeza · 2020-04-01T19:10:56Z

would you mind me to take over it?

No, go ahead. I have rebased the PR.

jdneo · 2020-04-11T11:54:14Z

@snjeza Oops... I found that I have no permission to update commits into your branch.

jdneo · 2020-04-12T10:50:28Z

Thank you @snjeza, I can update now. 😄
I removed the auto-detection logic, since in some cases, we cannot handle it well. But I think we can address the auto-detection thing in the future when we find out some suitable way to do that.

Let's first introduce the import project command to unblock the users. And please feel free to let me know if you have any concerns.

// BTW, the permission of the vscode-client repo is needed as well. 😄

jdneo · 2020-04-12T12:02:04Z

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/ProjectsManager.java

@@ -192,6 +213,8 @@ public void cleanupResources(IProject project) throws CoreException {
 					File f = new File(cu.getUnderlyingResource().getLocationURI());
 					if (!f.exists()) {
 						cu.delete(true, null);
+					} else {
+						JDTUtils.resolveCompilationUnit(f.toURI());


@snjeza Do you remember why this line is needed?

You can check the issue by adding che (https://github.com/eclipse/che) to a workspace.

testforstephen · 2020-04-27T03:13:18Z

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/ProjectsManager.java

+				try {
+					importProjects(preferenceManager.getPreferences().getRootPaths(), monitor);
+				} catch (OperationCanceledException e) {
+					JavaLanguageServerPlugin.logInfo("Initialization has been cancelled.");


Importing projects job has been cancelled.

testforstephen · 2020-04-27T03:13:35Z

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/ProjectsManager.java

+				} catch (OperationCanceledException e) {
+					JavaLanguageServerPlugin.logInfo("Initialization has been cancelled.");
+				} catch (CoreException e) {
+					JavaLanguageServerPlugin.logException("Initialization failed ", e);


Importing projects failed

Signed-off-by: Sheng Chen <[email protected]>

jdneo · 2020-05-06T07:58:56Z

@fbricon, ping...

jdneo · 2020-05-16T05:19:23Z

@fbricon, ping...

jdneo · 2020-05-17T08:43:50Z

test this please

Signed-off-by: Sheng Chen <[email protected]>

fbricon · 2020-05-19T13:17:01Z

When triggering the import command but there's no more projects to import, this is logged:

[Error - 3:14:39 p.m.] May 19, 2020, 3:14:39 p.m. An internal error occurred during: "Importing projects in workspace...".
Job of type org.eclipse.jdt.ls.core.internal.managers.ProjectsManager$1 returned no status.
java.lang.NullPointerException: Job of type org.eclipse.jdt.ls.core.internal.managers.ProjectsManager$1 returned no status.
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:81)

fbricon · 2020-05-19T13:18:55Z

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/ProjectsManager.java

+				try {
+					importProjects(preferenceManager.getPreferences().getRootPaths(), monitor);
+				} catch (OperationCanceledException e) {
+					JavaLanguageServerPlugin.logInfo("Importing projects job has been cancelled.");


return failed status

fbricon · 2020-05-19T13:19:06Z

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/ProjectsManager.java

+					importProjects(preferenceManager.getPreferences().getRootPaths(), monitor);
+				} catch (OperationCanceledException e) {
+					JavaLanguageServerPlugin.logInfo("Importing projects job has been cancelled.");
+				} catch (CoreException e) {


return failed status

fbricon · 2020-05-19T13:19:13Z

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/ProjectsManager.java

+				} catch (CoreException e) {
+					JavaLanguageServerPlugin.logException("Importing projects failed.", e);
+				}
+				return null;


return Status.OK_STATUS

…into issue-144

Signed-off-by: Sheng Chen <[email protected]>

fbricon · 2020-05-20T20:46:26Z

Merged as 6e09b58

Thanks @snjeza and @jdneo!

snjeza requested review from gorkem and fbricon December 13, 2018 15:53

fbricon reviewed Dec 14, 2018

View reviewed changes

snjeza force-pushed the issue-144 branch from 18dfa0c to 29a3f50 Compare December 15, 2018 19:41

snjeza mentioned this pull request Dec 15, 2018

Expose import projects command redhat-developer/vscode-java#746

Merged

snjeza force-pushed the issue-144 branch from 29a3f50 to d58bb33 Compare December 21, 2018 18:12

snjeza mentioned this pull request Apr 8, 2019

Performance issues when adding lots of files #824

Open

snjeza changed the title ~~Recognize new maven, gradle, eclipse project(s) after first init~~ [WIP] Recognize new maven, gradle, eclipse project(s) after first init Apr 8, 2019

fbricon mentioned this pull request Jul 1, 2019

Java LS "Classpath is incomplete" warning when loading petclinic eclipse-che/che#13427

Open

snjeza added the in progress label Jul 3, 2019

snjeza force-pushed the issue-144 branch from d58bb33 to 55bee11 Compare July 9, 2019 15:35

snjeza changed the title ~~[WIP] Recognize new maven, gradle, eclipse project(s) after first init~~ Recognize new maven, gradle, eclipse project(s) after first init Jul 9, 2019

snjeza removed the in progress label Jul 9, 2019

tsmaeder mentioned this pull request Oct 11, 2019

Unable to see the highlight in the editor section for the Java debugging eclipse-che/che#14576

Closed

snjeza mentioned this pull request Jan 26, 2020

Multi-module Maven project does not work redhat-developer/vscode-java#1248

Open

snjeza force-pushed the issue-144 branch from 55bee11 to 131559f Compare January 26, 2020 15:59

fbricon reviewed Feb 3, 2020

View reviewed changes

snjeza force-pushed the issue-144 branch from 131559f to f6a9370 Compare February 3, 2020 19:37

snjeza force-pushed the issue-144 branch from f6a9370 to 598109e Compare April 1, 2020 19:07

jdneo reviewed Apr 12, 2020

View reviewed changes

jdneo force-pushed the issue-144 branch from 9f4bffb to d4450f8 Compare April 16, 2020 02:10

testforstephen reviewed Apr 27, 2020

View reviewed changes

jdneo added 2 commits April 27, 2020 13:23

Increasingly import project in workspace through command

b31cfd5

Signed-off-by: Sheng Chen <[email protected]>

Refine the wording

a68177f

Signed-off-by: Sheng Chen <[email protected]>

jdneo force-pushed the issue-144 branch from d4450f8 to a68177f Compare April 27, 2020 05:30

testforstephen approved these changes Apr 29, 2020

View reviewed changes

jdneo mentioned this pull request Apr 29, 2020

Prompt users to input during initialization … #1427

Closed

jdneo force-pushed the issue-144 branch from a68177f to 32a33f6 Compare May 16, 2020 03:55

jdneo force-pushed the issue-144 branch from 32a33f6 to 95986ff Compare May 16, 2020 06:56

Add new command to improt projects in workspace

480514e

Signed-off-by: Sheng Chen <[email protected]>

jdneo force-pushed the issue-144 branch from 95986ff to 480514e Compare May 19, 2020 03:22

fbricon requested changes May 19, 2020

View reviewed changes

jdneo added 2 commits May 20, 2020 12:44

Merge branch 'issue-144' of https://github.com/snjeza/eclipse.jdt.ls …

7c67084

…into issue-144

Return Status instance

4098178

Signed-off-by: Sheng Chen <[email protected]>

fbricon closed this May 20, 2020

Recognize new maven, gradle, eclipse project(s) after first init #901

Recognize new maven, gradle, eclipse project(s) after first init #901

Conversation

snjeza commented Dec 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fbricon Dec 14, 2018 • edited Loading

Choose a reason for hiding this comment

snjeza commented Dec 14, 2018

fbricon commented Dec 15, 2018 • edited Loading

snjeza commented Dec 15, 2018

fbricon commented Dec 20, 2018

fbricon commented Dec 21, 2018

snjeza commented Dec 21, 2018

svor commented Dec 22, 2018

tsmaeder commented Mar 18, 2019

snjeza commented Jul 9, 2019 • edited Loading

snjeza commented Jan 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jdneo commented Mar 11, 2020

snjeza commented Mar 11, 2020

jdneo commented Mar 24, 2020

jdneo commented Apr 1, 2020

snjeza commented Apr 1, 2020

jdneo commented Apr 11, 2020 • edited Loading

jdneo commented Apr 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jdneo commented May 6, 2020

jdneo commented May 16, 2020

jdneo commented May 17, 2020

fbricon commented May 19, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fbricon commented May 20, 2020

snjeza commented Dec 13, 2018 •

edited

Loading

fbricon Dec 14, 2018 •

edited

Loading

fbricon commented Dec 15, 2018 •

edited

Loading

snjeza commented Jul 9, 2019 •

edited

Loading

jdneo commented Apr 11, 2020 •

edited

Loading