Source Action: Override/Implement Methods with prompt #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Peer PR on vscode-java side: redhat-developer/vscode-java#749 |
fbricon
requested changes
Dec 21, 2018
fbricon
reviewed
Jan 9, 2019
....jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/text/correction/SourceAssistProcessor.java
Show resolved
Hide resolved
fbricon
reviewed
Jan 9, 2019
....jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/text/correction/SourceAssistProcessor.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
Jan 9, 2019
....ls.tests/src/org/eclipse/jdt/ls/core/internal/codemanipulation/OverrideMethodsTestCase.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
Jan 9, 2019
....ls.core/src/org/eclipse/jdt/ls/core/internal/codemanipulation/OverrideMethodsOperation.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
Jan 9, 2019
| return overridables; | ||
| } | ||
|
|
||
| public static TextEdit addOverridableMethods(IType type, OverridableMethod[] overridableMethods) { |
There was a problem hiding this comment.
what happens if overridableMethods are actually already overridden (eg. call addOverridableMethods twice)?
There was a problem hiding this comment.
Generate duplicated code. Here i just take it as an utility method, and need the client to avoid calling the same code multiple times.
yaohaizh
force-pushed
the
jinbo_overridemethods
branch
2 times, most recently
from
fe81b6c to
51428ea
Compare
|
Try to resolve this PR since @testforstephen is still on leave. But there is ip validation issue, wait for @testforstephen to come back and resolve this issue. |
Signed-off-by: Jinbo Wang <[email protected]>
testforstephen
force-pushed
the
jinbo_overridemethods
branch
from
51428ea to
b0d84e5
Compare
fbricon
requested changes
Feb 21, 2019
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/JDTLanguageServer.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/lsp/JavaProtocolExtensions.java
Outdated
Show resolved
Hide resolved
....ls.tests/src/org/eclipse/jdt/ls/core/internal/codemanipulation/OverrideMethodsTestCase.java
Outdated
Show resolved
Hide resolved
...clipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CodeActionHandlerTest.java
Outdated
Show resolved
Hide resolved
...clipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CodeActionHandlerTest.java
Outdated
Show resolved
Hide resolved
...clipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CodeActionHandlerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jinbo Wang <[email protected]>
|
Nice work @testforstephen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang [email protected]
It implements the source action
Override/Implement Methodswith prompt ui.Closes #900