Add code action: Generate toString()... #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinbo Wang <[email protected]>
Signed-off-by: Jinbo Wang <[email protected]>
fbricon
reviewed
Apr 9, 2019
| Assert.assertEquals(codeActions.get(0).getRight().getKind(), CodeActionKind.QuickFix); | ||
| Assert.assertEquals(codeActions.get(1).getRight().getKind(), CodeActionKind.QuickFix); | ||
| Assert.assertEquals(codeActions.get(2).getRight().getKind(), CodeActionKind.SourceOrganizeImports); | ||
| Assert.assertEquals(codeActions.get(3).getRight().getKind(), JavaCodeActionKind.SOURCE_OVERRIDE_METHODS); |
There was a problem hiding this comment.
why is this code action no longer returned?
There was a problem hiding this comment.
it still returned. I refactor this test case because this test method name is removeUnusedImport. Checking all code action list is just a byproduct. Every time, a new source action is added, we need fix this case. so i refactor this test case and let it focus on checking removeUnusedImport related code action only.
…ringBuilder Signed-off-by: Jinbo Wang <[email protected]>
|
test this please |
fbricon
requested changes
Apr 11, 2019
testforstephen
force-pushed
the
jinbo_tostring
branch
from
e0f51a4 to
efc9828
Compare
|
Nice finding. The toString source action will return a WorkspaceEdit directly if no non-static fields exist in the class. |
Signed-off-by: Jinbo Wang <[email protected]>
testforstephen
force-pushed
the
jinbo_tostring
branch
from
efc9828 to
b9eb9a6
Compare
|
test this please |
fbricon
reviewed
Apr 15, 2019
...lipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/GenerateToStringHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jinbo Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang [email protected]
Closes #736