Skip to content

Commit

Permalink
refactor(nm): move enums into org.eclipse.kura.nm.enums package (#4730
Browse files Browse the repository at this point in the history
)

* refactor: move NetworkManager enums into dedicated package

* refactor: change package

* fix: forgotten imports

* test: fix imports

* refactor: move enum test in related package

* fix: imports

* fix: remove unnecessary imports
  • Loading branch information
mattdibi authored Jun 23, 2023
1 parent bcc89dc commit 393fea1
Show file tree
Hide file tree
Showing 46 changed files with 68 additions and 54 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;

import org.eclipse.kura.nm.enums.NMDeviceState;
import org.freedesktop.dbus.connections.impl.DBusConnection;
import org.freedesktop.dbus.exceptions.DBusException;
import org.freedesktop.networkmanager.Device;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

import java.util.Objects;

import org.eclipse.kura.nm.enums.NMDeviceState;
import org.eclipse.kura.nm.enums.NMDeviceStateReason;
import org.freedesktop.dbus.exceptions.DBusException;
import org.freedesktop.dbus.interfaces.DBusSigHandler;
import org.freedesktop.networkmanager.Device;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@
import org.eclipse.kura.net.status.NetworkInterfaceStatus;
import org.eclipse.kura.net.wifi.WifiChannel;
import org.eclipse.kura.nm.configuration.NMSettingsConverter;
import org.eclipse.kura.nm.enums.MMModemLocationSource;
import org.eclipse.kura.nm.enums.MMModemState;
import org.eclipse.kura.nm.enums.NMDeviceState;
import org.eclipse.kura.nm.enums.NMDeviceType;
import org.eclipse.kura.nm.status.AccessPointsProperties;
import org.eclipse.kura.nm.status.DevicePropertiesWrapper;
import org.eclipse.kura.nm.status.NMStatusConverter;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

import java.util.concurrent.CountDownLatch;

import org.eclipse.kura.nm.enums.NMDeviceState;
import org.freedesktop.dbus.interfaces.DBusSigHandler;
import org.freedesktop.networkmanager.Device;
import org.slf4j.Logger;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import java.util.Objects;
import java.util.Timer;

import org.eclipse.kura.nm.enums.NMDeviceState;
import org.freedesktop.dbus.interfaces.DBusSigHandler;
import org.freedesktop.modemmanager1.Modem;
import org.freedesktop.networkmanager.Device;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@

import org.eclipse.kura.configuration.Password;
import org.eclipse.kura.nm.KuraIpStatus;
import org.eclipse.kura.nm.NMDeviceType;
import org.eclipse.kura.nm.NetworkProperties;
import org.eclipse.kura.nm.enums.NMDeviceType;
import org.freedesktop.dbus.types.UInt32;
import org.freedesktop.dbus.types.Variant;
import org.freedesktop.networkmanager.settings.Connection;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import java.util.EnumSet;
import java.util.Set;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import org.eclipse.kura.net.status.modem.RegistrationStatus;
import org.freedesktop.dbus.types.UInt32;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import java.util.EnumSet;
import java.util.Set;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import org.eclipse.kura.net.status.modem.ModemBand;
import org.freedesktop.dbus.types.UInt32;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import java.util.EnumSet;
import java.util.Set;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import java.util.EnumSet;
import java.util.Set;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import java.util.EnumSet;
import java.util.Set;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import org.eclipse.kura.net.status.modem.ModemPortType;
import org.freedesktop.dbus.types.UInt32;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import org.eclipse.kura.net.status.modem.ModemPowerState;
import org.freedesktop.dbus.types.UInt32;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import org.eclipse.kura.net.status.modem.ModemConnectionStatus;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import org.eclipse.kura.net.status.modem.ESimStatus;
import org.freedesktop.dbus.types.UInt32;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import org.eclipse.kura.net.status.modem.SimType;
import org.freedesktop.dbus.types.UInt32;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import java.util.ArrayList;
import java.util.Arrays;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import org.freedesktop.dbus.types.UInt32;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import java.util.Arrays;
import java.util.List;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import org.freedesktop.dbus.types.UInt32;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import org.freedesktop.dbus.types.UInt32;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import java.util.ArrayList;
import java.util.Arrays;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

import java.util.Optional;

import org.eclipse.kura.nm.NMDeviceType;
import org.eclipse.kura.nm.enums.NMDeviceType;
import org.freedesktop.dbus.interfaces.Properties;

public class DevicePropertiesWrapper {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,22 +57,22 @@
import org.eclipse.kura.net.status.wifi.WifiMode;
import org.eclipse.kura.net.status.wifi.WifiSecurity;
import org.eclipse.kura.net.wifi.WifiChannel;
import org.eclipse.kura.nm.MMBearerIpFamily;
import org.eclipse.kura.nm.MMModem3gppRegistrationState;
import org.eclipse.kura.nm.MMModemAccessTechnology;
import org.eclipse.kura.nm.MMModemBand;
import org.eclipse.kura.nm.MMModemCapability;
import org.eclipse.kura.nm.MMModemLocationSource;
import org.eclipse.kura.nm.MMModemMode;
import org.eclipse.kura.nm.MMModemPortType;
import org.eclipse.kura.nm.MMModemPowerState;
import org.eclipse.kura.nm.MMModemState;
import org.eclipse.kura.nm.MMSimEsimStatus;
import org.eclipse.kura.nm.MMSimType;
import org.eclipse.kura.nm.NM80211ApSecurityFlags;
import org.eclipse.kura.nm.NM80211Mode;
import org.eclipse.kura.nm.NMDeviceState;
import org.eclipse.kura.nm.NMDeviceWifiCapabilities;
import org.eclipse.kura.nm.enums.MMBearerIpFamily;
import org.eclipse.kura.nm.enums.MMModem3gppRegistrationState;
import org.eclipse.kura.nm.enums.MMModemAccessTechnology;
import org.eclipse.kura.nm.enums.MMModemBand;
import org.eclipse.kura.nm.enums.MMModemCapability;
import org.eclipse.kura.nm.enums.MMModemLocationSource;
import org.eclipse.kura.nm.enums.MMModemMode;
import org.eclipse.kura.nm.enums.MMModemPortType;
import org.eclipse.kura.nm.enums.MMModemPowerState;
import org.eclipse.kura.nm.enums.MMModemState;
import org.eclipse.kura.nm.enums.MMSimEsimStatus;
import org.eclipse.kura.nm.enums.MMSimType;
import org.eclipse.kura.nm.enums.NM80211ApSecurityFlags;
import org.eclipse.kura.nm.enums.NM80211Mode;
import org.eclipse.kura.nm.enums.NMDeviceState;
import org.eclipse.kura.nm.enums.NMDeviceWifiCapabilities;
import org.freedesktop.dbus.exceptions.DBusExecutionException;
import org.freedesktop.dbus.interfaces.Properties;
import org.freedesktop.dbus.types.UInt32;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@
import org.eclipse.kura.net.status.modem.RegistrationStatus;
import org.eclipse.kura.net.status.modem.Sim;
import org.eclipse.kura.net.status.modem.SimType;
import org.eclipse.kura.nm.enums.MMModemLocationSource;
import org.eclipse.kura.nm.enums.NMDeviceState;
import org.eclipse.kura.nm.enums.NMDeviceType;
import org.freedesktop.ModemManager1;
import org.freedesktop.NetworkManager;
import org.freedesktop.dbus.DBusPath;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;

import org.eclipse.kura.nm.enums.NMDeviceState;
import org.eclipse.kura.nm.enums.NMDeviceStateReason;
import org.freedesktop.dbus.exceptions.DBusException;
import org.freedesktop.modemmanager1.Modem;
import org.freedesktop.networkmanager.Device;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
import java.util.Optional;

import org.eclipse.kura.configuration.Password;
import org.eclipse.kura.nm.NMDeviceType;
import org.eclipse.kura.nm.NetworkProperties;
import org.eclipse.kura.nm.enums.NMDeviceType;
import org.freedesktop.dbus.types.UInt32;
import org.freedesktop.dbus.types.Variant;
import org.freedesktop.networkmanager.settings.Connection;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import static org.junit.Assert.assertEquals;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import static org.junit.Assert.assertEquals;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import static org.junit.Assert.assertEquals;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import static org.junit.Assert.assertEquals;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import static org.junit.Assert.assertEquals;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import static org.junit.Assert.assertEquals;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import static org.junit.Assert.assertEquals;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import static org.junit.Assert.assertEquals;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import static org.junit.Assert.assertEquals;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import static org.junit.Assert.assertEquals;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Contributors:
* Eurotech
*******************************************************************************/
package org.eclipse.kura.nm;
package org.eclipse.kura.nm.enums;

import static org.junit.Assert.assertEquals;

Expand Down
Loading

0 comments on commit 393fea1

Please sign in to comment.