fix: Fixed NPE on sqlite activator stop (#4773)

Signed-off-by: Nicola Timeus <[email protected]>
eclipse-kura · Jul 20, 2023 · a92d199 · a92d199
1 parent 096b2b9
commit a92d199
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 2 deletions.
diff --git a/...r/src/main/java/org/eclipse/kura/internal/db/sqlite/provider/SqliteProviderActivator.java b/...r/src/main/java/org/eclipse/kura/internal/db/sqlite/provider/SqliteProviderActivator.java
@@ -42,7 +42,7 @@ public void start(final BundleContext context) throws Exception {
     @Override
     public void stop(final BundleContext context) throws Exception {
         if (locationChanged) {
-            System.setProperty(SQLITE_TMPDIR_PROPERTY_KEY, null);
+            System.clearProperty(SQLITE_TMPDIR_PROPERTY_KEY);
         }
     }
 

diff --git a/...c/test/java/org/eclipse/kura/internal/db/sqlite/provider/SqliteProviderActivatorTest.java b/...c/test/java/org/eclipse/kura/internal/db/sqlite/provider/SqliteProviderActivatorTest.java
@@ -27,6 +27,7 @@ public class SqliteProviderActivatorTest {
 
     @Test
     public void shouldSetSqliteTempDirIfUnset() {
+        givenNoSystemPropertyValue("org.sqlite.tmpdir");
         givenBundleStorageAreaPath("/tmp/foo");
 
         whenActivatorIsStarted();
@@ -37,6 +38,7 @@ public void shouldSetSqliteTempDirIfUnset() {
 
     @Test
     public void shouldNotSetSqliteTempDirIfBundleStorageAreaIsNotAvailable() {
+        givenNoSystemPropertyValue("org.sqlite.tmpdir");
         givenNoBundleStorageArea();
 
         whenActivatorIsStarted();
@@ -67,9 +69,34 @@ public void shouldNotChangeSqliteTempDirIfSetAndExisting() {
         thenSystemPropertyValueIs("org.sqlite.tmpdir", temporaryDirectoryPath());
     }
 
+    @Test
+    public void shouldClearSqliteTempDirOnStopIfChanged() {
+        givenNoSystemPropertyValue("org.sqlite.tmpdir");
+        givenBundleStorageAreaPath("/tmp/foo");
+        givenStartedActivator();
+
+        whenActivatorIsStopped();
+
+        thenNoExceptionIsThrown();
+        thenSystemPropertyValueIs("org.sqlite.tmpdir", null);
+    }
+
+    @Test
+    public void shouldNotClearSqliteTempDirOnStopIfNotChanged() {
+        givenSystemProperty("org.sqlite.tmpdir", temporaryDirectoryPath());
+        givenBundleStorageAreaPath("/tmp/foo");
+        givenStartedActivator();
+
+        whenActivatorIsStopped();
+
+        thenNoExceptionIsThrown();
+        thenSystemPropertyValueIs("org.sqlite.tmpdir", temporaryDirectoryPath());
+    }
+
     private final BundleContext bundleContext = Mockito.mock(BundleContext.class);
     private Optional<Exception> exception = Optional.empty();
     private Optional<String> temporaryDirectoryPath = Optional.empty();
+    private SqliteProviderActivator activator = new SqliteProviderActivator();
 
     private void givenBundleStorageAreaPath(String path) {
         Mockito.when(bundleContext.getDataFile("")).thenReturn(new File(path));
@@ -83,9 +110,28 @@ private void givenSystemProperty(final String key, final String value) {
         System.setProperty(key, value);
     }
 
+    private void givenNoSystemPropertyValue(final String key) {
+        System.clearProperty(key);
+    }
+
+    private void givenStartedActivator() {
+        whenActivatorIsStarted();
+        thenNoExceptionIsThrown();
+    }
+
     private void whenActivatorIsStarted() {
         try {
-            new SqliteProviderActivator().start(bundleContext);
+            this.exception = Optional.empty();
+            activator.start(bundleContext);
+        } catch (Exception e) {
+            this.exception = Optional.of(e);
+        }
+    }
+
+    private void whenActivatorIsStopped() {
+        try {
+            this.exception = Optional.empty();
+            activator.stop(bundleContext);
         } catch (Exception e) {
             this.exception = Optional.of(e);
         }