Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommConnectionImpl constructor does not close the serial port on failure #2822

Closed
nicolatimeus opened this issue Apr 29, 2020 · 0 comments · Fixed by #2823
Closed

CommConnectionImpl constructor does not close the serial port on failure #2822

nicolatimeus opened this issue Apr 29, 2020 · 0 comments · Fixed by #2823
Assignees
@nicolatimeus
Labels
bug

Comments

@nicolatimeus
Copy link
Contributor

Describe the bug
If the CommConnectionImpl constructor is able to create a comm port but the configuration operations performed at [1] fail, the port will not be closed. This can leak resources held by the underlying serial library, such as lock files.

[1] https://github.com/eclipse/kura/blob/2ff4bf772e768658098318e464e430ab30973456/kura/org.eclipse.kura.core.comm/src/main/java/org/eclipse/kura/core/comm/CommConnectionImpl.java#L91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolatimeus nicolatimeus

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed CommConnectionImpl constructor not closing serial port on failure nicolatimeus/kura
2 participants
@nicolatimeus @MMaiero