Added check for resolv.conf symlink #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pierantoniomerlino <[email protected]>
MMaiero
reviewed
Jan 7, 2019
| @@ -367,6 +370,17 @@ private synchronized String getRealPath(File file) throws KuraException { | |||
|
|
|||
| private synchronized void writeDnsFile(Set<IPAddress> servers) { | |||
| logger.debug("Writing DNS servers to file"); | |||
| // Check if DNS_FILE_NAME is a symlink and it is broken or points to unmanaged location. | |||
| // In this case, delete it. | |||
| try { | |||
There was a problem hiding this comment.
Maybe move this block to a specific method with a meaningful name, in order to be able to remove the comment.
Signed-off-by: nicolatimeus <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pierantoniomerlino [email protected]
Brief description of the PR.
If the resolv.conf file is a symlink, Kura fails to write the DNS servers on it. This PR adds a check before writing on that file.