feat(org.eclipse.kura.container.orchestrator): adding support for image-management via inventory API #3953
Conversation
MMaiero
force-pushed
the
image-managment-support-container-orchestrator-inventory-api-2
branch
from
8072623 to
b15310a
Compare
|
@GregoryIvo I have rebased the branch to match the latest changes. |
GregoryIvo
changed the title
GregoryIvo
changed the title
| @@ -12,7 +12,7 @@ Import-Package: | |||
| org.eclipse.kura;version="[1.0,2.0)", | |||
| org.eclipse.kura.executor;version="[1.0,2.0)", | |||
| org.eclipse.kura.net;version="[2.0,3.0)", | |||
| org.eclipse.kura.system;version="[1.5,1.6)", | |||
| org.eclipse.kura.system;version="[1.5,2.0)", | |||
There was a problem hiding this comment.
I think this implements the system apis and should be [1.6,1.7). Maybe have a look at this to understand better the versioning scheme adopted by Kura: https://github.com/eclipse/kura/wiki/Kura-Semantic-Versioning
There was a problem hiding this comment.
ahh, so because it's a provider it should only be major.minor+1) instead of major+1.minor)?
|
For some strange reason, there appears to be a discrepancy between what sonar cloud says, and what my local eclipse reports? Currently attempting to find a solution to this, may just need to write more tests.
|
…opertiy from resources.ContainerImage, as it was unecessary
|
Decided to mitigate that issue by just writing more tests! Everything should be good now |
| @@ -25,6 +25,7 @@ public enum SystemResourceType { | |||
| RPM, | |||
| DEB, | |||
| DOCKER, | |||
| CONTAINER_IMAGE, | |||
There was a problem hiding this comment.
/**
* @since 2.4
*/
CONTAINER_IMAGE,
An annotation like this is needed here
| @@ -12,7 +12,7 @@ Import-Package: | |||
| org.eclipse.kura;version="[1.0,2.0)", | |||
| org.eclipse.kura.executor;version="[1.0,2.0)", | |||
| org.eclipse.kura.net;version="[2.0,3.0)", | |||
| org.eclipse.kura.system;version="[1.5,1.6)", | |||
| org.eclipse.kura.system;version="[1.5,1.7)", | |||
| @@ -10,7 +10,7 @@ Import-Package: org.eclipse.equinox.http.jetty;version="1.5.0", | |||
| org.eclipse.kura.configuration;version="1.2.0", | |||
| org.eclipse.kura.crypto;version="[1.2,2.0)", | |||
| org.eclipse.kura.security.keystore;version="[1.0,2.0)", | |||
| org.eclipse.kura.system;version="1.4.0", | |||
| org.eclipse.kura.system;version="[1.5,2.0)", | |||
There was a problem hiding this comment.
Why not [1.6,2.0)? since the system api is now 1.6
| @@ -11,7 +11,7 @@ Bundle-ActivationPolicy: lazy | |||
| Import-Package: jdk.dio;version="1.0.1", | |||
| jdk.dio.gpio;version="1.0.1", | |||
| org.eclipse.kura.gpio;version="[1.1,1.2)", | |||
| org.eclipse.kura.system;version="1.0.0", | |||
| org.eclipse.kura.system;version="[1.0,2.0)", | |||
There was a problem hiding this comment.
Probably better to have it also in the range [1.6,2.0)
Related Issue: This PR fixes/closes {issue number}
Description of the solution adopted: A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to inderstand this section can be skipped.
Screenshots: If applicable, add screenshots to help explain your solution
Any side note on the changes made: Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]