Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Initial support for custom REST authentication providers #3982

Merged
merged 5 commits into from
May 16, 2022
Merged

feat: Initial support for custom REST authentication providers #3982

merged 5 commits into from
May 16, 2022

Conversation

nicolatimeus
Copy link
Contributor

Brief description of the PR. [e.g. Added null check on object to avoid NullPointerException]

  • Adds API for defining custom REST authentication providers
  • Added configuration options to disable built-in authentication methods
  • Fixed REST requests without authentication on non-secured resources
  • Added authentication provider example bundle

@MMaiero
Copy link
Contributor

MMaiero commented May 13, 2022

@ashmookler1 Can you please have a review?

@nicolatimeus
doc: Improved javadoc comment
b6a9c8b 
Signed-off-by: Nicola Timeus <[email protected]>
MMaiero
MMaiero reviewed May 16, 2022
View reviewed changes
kura/examples/org.eclipse.kura.example.rest.authentication.provider/META-INF/MANIFEST.MF Outdated
Comment on lines 15 to 16
org.eclipse.kura.audit;version="1.0.0",
org.eclipse.kura.crypto;version="1.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Range needed

...org/eclipse/kura/example/rest/authentication/provider/ExampleRestAuthenticationProvider.java Outdated

final String passwordHash = (String) user.getCredentials().get(KURA_PASSWORD_CREDENTIAL);

if (passwordHash == null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Objects.isNull?

@ashmookler1
Copy link

ashmookler1 commented May 16, 2022 •
edited
Loading

@ashmookler1 Can you please have a review?

@MMaiero This looks good to me from a high level overview. I think this provides what is needed. Thank you!

@MMaiero MMaiero merged commit 8b4726b into eclipse-kura:develop May 16, 2022
@nicolatimeus nicolatimeus deleted the feature_custom-rest-auth branch March 22, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MMaiero MMaiero MMaiero approved these changes

@ashmookler1 ashmookler1 ashmookler1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolatimeus @MMaiero @ashmookler1