feat(ai.triton.server): expose "timeout" parameter for long running operations #4017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
This reverts commit 6bf462d.
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
…hods Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
…tion Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
|
For whatever reason the Sonar status is missing. Here's the direct link. |
MMaiero
reviewed
Jun 14, 2022
...ai.triton.server/OSGI-INF/metatype/org.eclipse.kura.ai.triton.server.TritonServerService.xml
Outdated
Show resolved
Hide resolved
MMaiero
reviewed
Jun 14, 2022
...erver.test/src/test/java/org/eclipse/kura/ai/triton/server/TritonServerLocalManagerTest.java
Show resolved
Hide resolved
MMaiero
reviewed
Jun 14, 2022
...ver.test/src/test/java/org/eclipse/kura/ai/triton/server/TritonServerServiceOptionsTest.java
Show resolved
Hide resolved
Signed-off-by: Mattia Dal Ben <[email protected]>
Signed-off-by: Mattia Dal Ben <[email protected]>
MMaiero
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed "timeout" parameter to the user for long running operations.
Description of the solution adopted: Added "timeout" (in seconds) for time consuming tasks like server startup, shutdown or model load. If the task exceeds the timeout the operation will be terminated with an error.
This "timeout" parameter substitutes the fixed number of attempts we were performing for the above-mentioned operations since the time taken by these heavily depends on hardware and software configuration (amount of model loaded in the server).
Additionally a new
kill()method was added to theTritonServerLocalManagerfor killing a non-responsive process.