Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support topic names using "//" or wildcards #4065

Closed
wants to merge 1 commit into from
Closed

fix: support topic names using "//" or wildcards #4065

wants to merge 1 commit into from

Conversation

spulci
Copy link

@spulci spulci commented Jul 27, 2022

Support topic names using "//" or wildcards

Related Issue: This PR closes #3972

Description of the solution adopted: Embedded Paho Client Mqttv3 jar version 1.2.1 contains a bug (eclipse-paho/paho.mqtt.java#718) that brakes Kura Cloud Connections to topics with names cointaining wildcards or "//". The bug has been fixed since version 1.2.3; this contrib updates the embedded version to the lastest Paho stable release 1.2.5

Embedded Paho Client Mqttv3 jar version 1.2.1 contains a bug (eclipse-paho/paho.mqtt.java#718) that brakes Kura Cloud Connections to topics with names cointaining wildcards or "//".  The bug has been fixed since version 1.2.3; this contrib updates the embedded version to the lastest Paho stable release 1.2.5

close issue #3972

Signed-off-by: Simone Pulcini <[email protected]>
@spulci spulci marked this pull request as draft July 27, 2022 12:13
@MMaiero MMaiero requested a review from nicolatimeus July 27, 2022 13:35
@spulci
Copy link
Author

spulci commented Jul 27, 2022

@MMaiero I need your help troubleshooting this issue. The PR has an issue on MQTT tests using SSL. You may have a look at the CI log

Caused by: org.eclipse.paho.client.mqttv3.MqttException: MqttException
Caused by: javax.net.ssl.SSLHandshakeException: No name matching localhost found
Caused by: java.security.cert.CertificateException: No name matching localhost found

@MMaiero
Copy link
Contributor

MMaiero commented Jul 27, 2022

Hi, did you have a look if this is a known issue of version 1.2.5?
If the tests were working before with the previous version of Paho, maybe they have added a change that is a breaking change.

@spulci
Copy link
Author

spulci commented Jul 27, 2022

Hi, did you have a look if this is a known issue of version 1.2.5? If the tests were working before with the previous version of Paho, maybe they have added a change that is a breaking change.

Nope. Versione 1.2.1-k2 is a fork:

#2794

Kura is actually using a modified version of Paho as reported in that PR. We do not encount any kind of issue in our test on Kura 4.1.3 due to the fact we're not using SSL yet. Hopefully I will port the same fixes on 1.2.5, releasing a forked version for you if the code base is not so different from 1.2.1

I was not aware of this fork, sorry

@MMaiero
Copy link
Contributor

MMaiero commented Jul 28, 2022

Yes, we have created that fork due to some unresolved issues in paho and their threading model that would leave dangling threads over time. I think there is still an issue in their repo that I have open-end and probably also a PR. But those were never addressed by the pho committers.

But the issue seems related to tests failing with 1.2.5 that were previously passing with 1.2.1 (independently from the fork). So that's why I have asked the question.
It may be that there is an issue in 1.2.5 or a breaking change that requires changes to the tests.

@MMaiero MMaiero removed the request for review from nicolatimeus July 28, 2022 09:11
@spulci
Copy link
Author

spulci commented Jul 28, 2022

A real bad day for me.. I have deleted my forked kura repo inadvertently :( I will come back with a new PR when I will have a fixed version of embedded Paho too....so sorry :(

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topic name validation: issue with names containing "//" (Cloud Subscriber)
2 participants