fix(core.configuration): fix SelfConfiguringComponent default configuration retrival #4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
nicolatimeus
reviewed
Aug 2, 2022
| } | ||
|
|
||
| private ComponentConfiguration getSelfConfiguringComponentDefaultConfigurationInternal(Object obj, String pid) { | ||
| ComponentConfiguration cc = null; |
There was a problem hiding this comment.
This cc variable is never modified
|
The changes seem to work |
…l method Signed-off-by: pierantoniomerlino <[email protected]>
nicolatimeus
approved these changes
Aug 2, 2022
|
verified as fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the retrival of the default configuration for
SelfConfiguringComponents.Related Issue: This PR fixes/closes N/A
Description of the solution adopted: As done for the
ConfigurableComponents, thegetDefaultComponentConfigurationin theConfigurationServiceImplis modified to handle also the default configurations ofSelfConfiguringComponents. Using the rest call{app}}/services/configuration/v2/configurableComponents/configurations/byPid/_defaultfor aSelfConfiguringComponentlike theFirewallConfigurationService, now it is possible to get the default configuration.