feat(wire.CloudPublisher): Set as body a property removing it from metrics #4328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcomatteo
force-pushed
the
enh_wire_cloud_publisher
branch
from
5b4878d to
bdb9abd
Compare
…lso to metrics Signed-off-by: Marco Matteo Buzzulini <[email protected]>
marcomatteo
force-pushed
the
enh_wire_cloud_publisher
branch
from
9fc48af to
638df85
Compare
…tor the tests Signed-off-by: Marco Matteo Buzzulini <[email protected]>
marcomatteo
force-pushed
the
enh_wire_cloud_publisher
branch
from
638df85 to
eb124c4
Compare
marcomatteo
changed the title
marcellorinaldo
requested changes
Jan 25, 2023
...ipse.kura.wire.component.provider/OSGI-INF/metatype/org.eclipse.kura.wire.CloudPublisher.xml
Outdated
Show resolved
Hide resolved
...omponent.provider/src/main/java/org/eclipse/kura/internal/wire/publisher/CloudPublisher.java
Outdated
Show resolved
Hide resolved
...omponent.provider/src/main/java/org/eclipse/kura/internal/wire/publisher/CloudPublisher.java
Outdated
Show resolved
Hide resolved
...t.provider/src/main/java/org/eclipse/kura/internal/wire/publisher/CloudPublisherOptions.java
Outdated
Show resolved
Hide resolved
...t.provider/src/main/java/org/eclipse/kura/internal/wire/publisher/CloudPublisherOptions.java
Outdated
Show resolved
Hide resolved
...omponent.provider/src/main/java/org/eclipse/kura/internal/wire/publisher/CloudPublisher.java
Outdated
Show resolved
Hide resolved
|
Thanks for the PR @marcomatteo. When you have the time, could you please address the review? |
|
Thank you @marcellorinaldo for the review. I'll answer and fix soon. |
Signed-off-by: Marco Matteo Buzzulini <[email protected]>
Signed-off-by: Marco Matteo Buzzulini <[email protected]>
Signed-off-by: Marco Matteo Buzzulini <[email protected]>
|
Hi @marcomatteo, Thanks |
|
Hi @MMaiero, |
|
Also here, the Eclipse CI cannot retrieve Sonar status for Kura project.
|
marcellorinaldo
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "remove.body.from.metrics" boolean property in the component metatype.
If set to True and the "set a property as body" is not empty, remove the property from the KuraPayload metrics and KuraMessage properties.
The default value is false and preserve the current behaviour.
Added the test cases and refactor the CloudPublisherTest class with scenarios.
Related Issue: This PR fixes the issue #4292