feat(web2): Updated web2 for the new network service #4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pierantoniomerlino <[email protected]>
marcellorinaldo
approved these changes
Feb 1, 2023
nicolatimeus
reviewed
Feb 1, 2023
| @@ -50,8 +50,7 @@ | |||
| import org.eclipse.kura.web.server.GwtKeystoreServiceImpl; | |||
| import org.eclipse.kura.web.server.GwtLogServiceImpl; | |||
| import org.eclipse.kura.web.server.GwtLoginInfoServiceImpl; | |||
| import org.eclipse.kura.web.server.GwtNetworkServiceImpl; | |||
| import org.eclipse.kura.web.server.GwtPackageServiceImpl; | |||
| import org.eclipse.kura.web.server.GwtNetworkServiceImplFacade; | |||
There was a problem hiding this comment.
Please update copyright header
nicolatimeus
reviewed
Feb 1, 2023
| @@ -0,0 +1,426 @@ | |||
| package org.eclipse.kura.web.server.net2.utils; | |||
There was a problem hiding this comment.
Copyright header is missing
Signed-off-by: pierantoniomerlino <[email protected]>
nicolatimeus
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the web2 bundle for the new network services that will be implemented in #4326.
The code is developed by @marcellorinaldo and I've only extracted it from the #4326 and put in a separate PR.
Related Issue: This PR fixes/closes N/A
Description of the solution adopted: In order to be compatible with the old network services, the
GwtNetworkServiceImplFacadeis used to hide the implementation. If theNetworkAdminServiceis found, the oldGwtNetworkServiceImplwill be used. If, instead, it is not present, the newGwtNetworkServiceImpland the newNetworkStatusServicewill be used for retrieving the network configuration and status.Signed-off-by: pierantoniomerlino [email protected]