Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added option to delete database files on failure in SQLite #4432

Merged
merged 2 commits into from
Mar 7, 2023
Merged

feat: Added option to delete database files on failure in SQLite #4432

merged 2 commits into from
Mar 7, 2023

Conversation

nicolatimeus
Copy link
Contributor

Note: We are using the Conventional Commits convention for our pull request titles. Please take a look at the PR title format document for the supported types and scopes.

Brief description of the PR. [e.g. Added null check on object to avoid NullPointerException]

  • Added an option to SQLite db service to delete database files if database cannot be opened, enabled by default to match the behavior of the H2DbService implementation
  • Added sanitization of Db url
  • Fixed inconsistencies between metatype and options default parameter values

@MMaiero MMaiero requested a review from marcellorinaldo March 6, 2023 14:29
@nicolatimeus
Fixed log message
8810ec6 
Signed-off-by: Nicola Timeus <[email protected]>
@MMaiero MMaiero merged commit 6489316 into eclipse-kura:develop Mar 7, 2023
@nicolatimeus nicolatimeus deleted the feat_sqlite-delete-db-files-on-open-failure branch March 22, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcellorinaldo marcellorinaldo marcellorinaldo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolatimeus @marcellorinaldo @MMaiero