feat(dhcp-server): added dnsmasq support [Backport] #4498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(web): adjusted properties related to NAT and router mode Signed-off-by: Marcello Martina <[email protected]> * build(distrib): added dnsmasq dependency Signed-off-by: Marcello Martina <[email protected]> * feat(dhpc): added dnsmasq support for dhcp server Signed-off-by: Marcello Martina <[email protected]> * fix: allow search for dns server in localhost only when option is enabled Signed-off-by: Marcello Martina <[email protected]> * style: added comments to explain numeric options Signed-off-by: Marcello Martina <[email protected]> * feat: more robust isRunning method, added debug logs Signed-off-by: Marcello Martina <[email protected]> * fix: tweaked dnsmasq setting Signed-off-by: Marcello Martina <[email protected]> --------- Signed-off-by: Marcello Martina <[email protected]>
marcellorinaldo
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.