fix(nm): avoid error when Modem.Location interface is missing
#4516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdibi
changed the title
Modem.Location interface is missing
kura/org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/NMDbusConnector.java
Show resolved
Hide resolved
pierantoniomerlino
approved these changes
Apr 3, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2023
* fix(nm): avoid error when Modem.Location interface is missing * fix: simplify logic * fix: do not call Location.Setup if there's no location source available * fix: change log level (cherry picked from commit b01a813)
mattdibi
added a commit
that referenced
this pull request
Apr 4, 2023
…port release-5.3.0] (#4522) fix(nm): avoid error when `Modem.Location` interface is missing (#4516) * fix(nm): avoid error when Modem.Location interface is missing * fix: simplify logic * fix: do not call Location.Setup if there's no location source available * fix: change log level (cherry picked from commit b01a813) Co-authored-by: Mattia Dal Ben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per ModemManager DBus API documentation, the
Modem.Locationinterface:This meant that, it was possible to find this error during Modem configuration:
This PR add the required checks to avoid throwing errors due to the lack of the
Modem.Locationinterface during Modem configuration.