test(nm.configuration.writer): refactor and added tests dnsmasq cases for DhcpServerConfigWriter #4520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for DhcpServerConfigWriter Signed-off-by: Marcello Martina <[email protected]>
mattdibi
reviewed
Apr 3, 2023
....test/src/test/java/org/eclipse/kura/nm/configuration/writer/DhcpServerConfigWriterTest.java
Outdated
Show resolved
Hide resolved
mattdibi
reviewed
Apr 3, 2023
....test/src/test/java/org/eclipse/kura/nm/configuration/writer/DhcpServerConfigWriterTest.java
Outdated
Show resolved
Hide resolved
mattdibi
reviewed
Apr 3, 2023
....test/src/test/java/org/eclipse/kura/nm/configuration/writer/DhcpServerConfigWriterTest.java
Outdated
Show resolved
Hide resolved
mattdibi
approved these changes
Apr 3, 2023
Signed-off-by: Marcello Martina <[email protected]>
No time but will for sure! |
mattdibi
approved these changes
Apr 4, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
… for DhcpServerConfigWriter (#4520) * test(nm.configuration.writer): refactor and added tests dnsmasq cases for DhcpServerConfigWriter Signed-off-by: Marcello Martina <[email protected]> * refactor: applied review suggestions Signed-off-by: Marcello Martina <[email protected]> --------- Signed-off-by: Marcello Martina <[email protected]> (cherry picked from commit 00bc216)
MMaiero
pushed a commit
that referenced
this pull request
Apr 5, 2023
… for DhcpServerConfigWriter [backport release-5.3.0] (#4528) test(nm.configuration.writer): refactor and added tests dnsmasq cases for DhcpServerConfigWriter (#4520) * test(nm.configuration.writer): refactor and added tests dnsmasq cases for DhcpServerConfigWriter Signed-off-by: Marcello Martina <[email protected]> * refactor: applied review suggestions Signed-off-by: Marcello Martina <[email protected]> --------- Signed-off-by: Marcello Martina <[email protected]> (cherry picked from commit 00bc216) Co-authored-by: Marcello Rinaldo Martina <[email protected]>
pierantoniomerlino
pushed a commit
that referenced
this pull request
Apr 5, 2023
… for DhcpServerConfigWriter (#4520) * test(nm.configuration.writer): refactor and added tests dnsmasq cases for DhcpServerConfigWriter Signed-off-by: Marcello Martina <[email protected]> * refactor: applied review suggestions Signed-off-by: Marcello Martina <[email protected]> --------- Signed-off-by: Marcello Martina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests cases for testing
DhcpServerConfigWriterin casednsmasqis used. Moreover, a refactor of the testing class is made to allow more parametrization of test cases and usage of Junit's temporary files.Related Issue: N/A.
Description of the solution adopted: N/A.
Screenshots: N/A.
Any side note on the changes made: N/A.