fix: Fixed NetworkConfigurationService returning passwords as strings #4532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicola Timeus <[email protected]>
marcellorinaldo
approved these changes
Apr 5, 2023
|
Sonar reports issues, can you please check? Thanks |
Signed-off-by: Nicola Timeus <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 5, 2023
…#4532) * fix: Fixed NetworkConfigurationService returning passwords as strings Signed-off-by: Nicola Timeus <[email protected]> * Added test for string wrapping as password Signed-off-by: Nicola Timeus <[email protected]> --------- Signed-off-by: Nicola Timeus <[email protected]> (cherry picked from commit 06e60ae)
nicolatimeus
added a commit
that referenced
this pull request
Apr 6, 2023
… [backport release-5.3.0] (#4539) fix: Fixed NetworkConfigurationService returning passwords as strings (#4532) * fix: Fixed NetworkConfigurationService returning passwords as strings Signed-off-by: Nicola Timeus <[email protected]> * Added test for string wrapping as password Signed-off-by: Nicola Timeus <[email protected]> --------- Signed-off-by: Nicola Timeus <[email protected]> (cherry picked from commit 06e60ae) Co-authored-by: nicolatimeus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NetworkConfigurationService is currently returning password fields as strings instead of Password objects for the configuration of the network interfaces that are present in the snapshot and not currently attached to the system.
This adds a check before its configuration is returned to wrap any string password property into a Password object.