refactor(nm): org.eclipse.kura.nm log cleanup/update
#4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierantoniomerlino
approved these changes
Apr 5, 2023
|
Do you prefer the info or debug level here? |
|
@pierantoniomerlino |
mattdibi
changed the title
org.eclipse.kura.nm log cleanup/update
pierantoniomerlino
approved these changes
Apr 5, 2023
|
Tests seem to fail. Expected? |
Uh... quite the opposite actually. Will look into it. |
mattdibi
force-pushed
the
matt/feat/log_entry_modem_reset
branch
from
ca525f0 to
7019e63
Compare
|
The current tests error seem unrelated to this PR and might be solved in #4544, will rebase after that merge. |
mattdibi
force-pushed
the
matt/feat/log_entry_modem_reset
branch
from
7019e63 to
3ed9657
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Apr 7, 2023
* refactor(nm): add missing log entry on modem reset cancel * refactor: lower overall log verbosity (cherry picked from commit 9b64377)
MMaiero
pushed a commit
that referenced
this pull request
Apr 7, 2023
…ase-5.3.0] (#4551) refactor(nm): `org.eclipse.kura.nm` log cleanup/update (#4535) * refactor(nm): add missing log entry on modem reset cancel * refactor: lower overall log verbosity (cherry picked from commit 9b64377) Co-authored-by: Mattia Dal Ben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
enableInterfacemethod that were not carrying much useful informations and cluttering the loggetAssociatedConnectionsmethod frominfotodebugclearTimermethod call. This allows for a better understanding of the overall timer status on the system and is consistent with the rest of the code.This is the resulting configuration log: