Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve the graph load time by reducing calls to bundleContext #4574

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

MMaiero
Copy link
Contributor

@MMaiero MMaiero commented Apr 15, 2023

Note: We are using the Conventional Commits convention for our pull request titles. Please take a look at the PR title format document for the supported types and scopes.

Brief description of the PR. [e.g. Added null check on object to avoid NullPointerException]

Related Issue: This PR fixes/closes {issue number}

Description of the solution adopted: A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to understand this section can be skipped.

Screenshots: If applicable, add screenshots to help explain your solution

Any side note on the changes made: Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]

MMaiero and others added 3 commits April 15, 2023 17:42
Signed-off-by: MMaiero <[email protected]>
Signed-off-by: Nicola Timeus <[email protected]>
Signed-off-by: Nicola Timeus <[email protected]>
@MMaiero MMaiero merged commit 2263134 into develop Apr 17, 2023
@MMaiero MMaiero deleted the feat_improve_graph_load_time branch April 17, 2023 12:37
github-actions bot pushed a commit that referenced this pull request Apr 17, 2023
…4574)

* feat: Improve the graph load time by reducing calls to bundleContext

Signed-off-by: MMaiero <[email protected]>

* fix: fixed tests

Signed-off-by: MMaiero <[email protected]>

* fix: Removed unused method

Signed-off-by: Nicola Timeus <[email protected]>

* Updated copyright headers

Signed-off-by: Nicola Timeus <[email protected]>

---------

Signed-off-by: MMaiero <[email protected]>
Signed-off-by: Nicola Timeus <[email protected]>
Co-authored-by: Nicola Timeus <[email protected]>
(cherry picked from commit 2263134)
MMaiero added a commit that referenced this pull request Apr 17, 2023
…[backport release-5.3.0] (#4575)

feat: Improve the graph load time by reducing calls to bundleContext (#4574)

* feat: Improve the graph load time by reducing calls to bundleContext

Signed-off-by: MMaiero <[email protected]>

* fix: fixed tests

Signed-off-by: MMaiero <[email protected]>

* fix: Removed unused method

Signed-off-by: Nicola Timeus <[email protected]>

* Updated copyright headers

Signed-off-by: Nicola Timeus <[email protected]>

---------

Signed-off-by: MMaiero <[email protected]>
Signed-off-by: Nicola Timeus <[email protected]>
Co-authored-by: Nicola Timeus <[email protected]>
(cherry picked from commit 2263134)

Co-authored-by: Matteo Maiero <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

The backport to release-5.2.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-5.2.0 release-5.2.0
# Navigate to the new working tree
cd .worktrees/backport-release-5.2.0
# Create a new branch
git switch --create backport-4574-to-release-5.2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 22631341ab838958717704118c80e026f7913233
# Push it to GitHub
git push --set-upstream origin backport-4574-to-release-5.2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-5.2.0

Then, create a pull request where the base branch is release-5.2.0 and the compare/head branch is backport-4574-to-release-5.2.0.

MMaiero added a commit that referenced this pull request May 3, 2023
…4574)

* feat: Improve the graph load time by reducing calls to bundleContext

Signed-off-by: MMaiero <[email protected]>

* fix: fixed tests

Signed-off-by: MMaiero <[email protected]>

* fix: Removed unused method

Signed-off-by: Nicola Timeus <[email protected]>

* Updated copyright headers

Signed-off-by: Nicola Timeus <[email protected]>

---------

Signed-off-by: MMaiero <[email protected]>
Signed-off-by: Nicola Timeus <[email protected]>
Co-authored-by: Nicola Timeus <[email protected]>
nicolatimeus added a commit that referenced this pull request May 3, 2023
* feat: Improve the graph load time by reducing calls to bundleContext (#4574)

* feat: Improve the graph load time by reducing calls to bundleContext

Signed-off-by: MMaiero <[email protected]>

* fix: fixed tests

Signed-off-by: MMaiero <[email protected]>

* fix: Removed unused method

Signed-off-by: Nicola Timeus <[email protected]>

* Updated copyright headers

Signed-off-by: Nicola Timeus <[email protected]>

---------

Signed-off-by: MMaiero <[email protected]>
Signed-off-by: Nicola Timeus <[email protected]>
Co-authored-by: Nicola Timeus <[email protected]>

* chore: updated version for wire provider bundle

Signed-off-by: MMaiero <[email protected]>

* chore: fixed versions

Signed-off-by: MMaiero <[email protected]>

---------

Signed-off-by: MMaiero <[email protected]>
Signed-off-by: Nicola Timeus <[email protected]>
Co-authored-by: Nicola Timeus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants