Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong PKCS11KeystoreServiceImpl bind methods #4676

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

MMaiero
Copy link
Contributor

@MMaiero MMaiero commented May 22, 2023

Note: We are using the Conventional Commits convention for our pull request titles. Please take a look at the PR title format document for the supported types and scopes.

Brief description of the PR. [e.g. Added null check on object to avoid NullPointerException]

Related Issue: This PR fixes/closes {issue number}

Description of the solution adopted: A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to understand this section can be skipped

Screenshots: If applicable, add screenshots to help explain your solution

Manual Tests: Optional description of the tests performed to check correct functioning of changes, useful for an efficient review

Any side note on the changes made: Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]

@MMaiero MMaiero merged commit 09a557f into develop May 23, 2023
@MMaiero MMaiero deleted the fix_pkcs11_ref branch May 23, 2023 07:27
MMaiero added a commit that referenced this pull request May 23, 2023
nicolatimeus pushed a commit that referenced this pull request May 23, 2023
….3.0] (#4681)

fix: Wrong PKCS11KeystoreServiceImpl bind methods (#4676)

Signed-off-by: MMaiero <[email protected]>
@github-actions
Copy link
Contributor

The backport to release-5.3.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-5.3.0 release-5.3.0
# Navigate to the new working tree
cd .worktrees/backport-release-5.3.0
# Create a new branch
git switch --create backport-4676-to-release-5.3.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09a557f133ad012f4abe92418ff1a683a0316d59
# Push it to GitHub
git push --set-upstream origin backport-4676-to-release-5.3.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-5.3.0

Then, create a pull request where the base branch is release-5.3.0 and the compare/head branch is backport-4676-to-release-5.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants