fix(core.deployment): dpa.properties is written even if package is already in persistence [backport release-5.3.0] #4692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ready in persistence (#4690) * fix(core.deployment): dpa.properties is written even if package is already in persistence Signed-off-by: Marcello Martina <[email protected]> * fix(core.deployment.agent): use '-' as version separator, always try to update dpa.properties Signed-off-by: Marcello Martina <[email protected]> * fix: Delete downloaded dp only if exist, otherwise exception is thrown Signed-off-by: Nicola Timeus <[email protected]> * fix: Use underscore for dps and dash for scripts Signed-off-by: Nicola Timeus <[email protected]> * fix(tests): fixed tests Signed-off-by: Marcello Martina <[email protected]> * revert: stored name is constructed from DP info from deploymentAgent and not from metrics Signed-off-by: Marcello Martina <[email protected]> * fix: Attempt to fix test Signed-off-by: Nicola Timeus <[email protected]> --------- Signed-off-by: Marcello Martina <[email protected]> Signed-off-by: Nicola Timeus <[email protected]> Co-authored-by: Nicola Timeus <[email protected]> (cherry picked from commit f952678)
MMaiero
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport f952678 from #4690.