feat(web.server.net2): add IPv6 configuration properties support #4804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
mattdibi
reviewed
Aug 14, 2023
...eclipse/kura/web/server/net2/configuration/NetworkConfigurationServicePropertiesBuilder.java
Outdated
Show resolved
Hide resolved
mattdibi
reviewed
Aug 14, 2023
...va/org/eclipse/kura/web/server/net2/configuration/NetworkConfigurationServiceProperties.java
Show resolved
Hide resolved
mattdibi
reviewed
Aug 14, 2023
...c/main/java/org/eclipse/kura/web/server/net2/configuration/GwtNetInterfaceConfigBuilder.java
Show resolved
Hide resolved
… instead of isNull Signed-off-by: Marcello Martina <[email protected]>
mattdibi
approved these changes
Aug 14, 2023
Signed-off-by: Marcello Martina <[email protected]>
pierantoniomerlino
pushed a commit
that referenced
this pull request
Sep 26, 2023
* feat(web.server.net2): added new IPv6 properties Signed-off-by: Marcello Martina <[email protected]> * feat(web.server.net2): add IPv6 configuration properties support Signed-off-by: Marcello Martina <[email protected]> * refactor(NetworkConfigurationServicePropertiesBuilder): using nonNull instead of isNull Signed-off-by: Marcello Martina <[email protected]> * refactor: populate ipv6 properties only when present Signed-off-by: Marcello Martina <[email protected]> --------- Signed-off-by: Marcello Martina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for the new IPv6 properties in the UI server part, it is a continuation of this PR: #4800.
Related Issue: N/A.
Description of the solution adopted: N/A.
Screenshots: N/A.
Manual Tests: N/A.
Any side note on the changes made: N/A.