feat: add BIRTH message caching on already connected connections for CloudConnectionManager implementations #4817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcellorinaldo
force-pushed
the
birth-message-caching
branch
from
6499379 to
d91d29d
Compare
marcellorinaldo
changed the title
… LifecycleMessage type Signed-off-by: Marcello Martina <[email protected]>
…buffer Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
…aching Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
marcellorinaldo
force-pushed
the
birth-message-caching
branch
from
da87957 to
07d3a56
Compare
Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
nicolatimeus
approved these changes
Sep 4, 2023
pierantoniomerlino
pushed a commit
that referenced
this pull request
Sep 26, 2023
…CloudConnectionManager implementations (#4817) * feat: add birth delay if already connected, refacored code to use new LifecycleMessage type Signed-off-by: Marcello Martina <[email protected]> * feat: APP certificates are always delayed and are kept in a separate buffer Signed-off-by: Marcello Martina <[email protected]> * refactor: added debug log messages Signed-off-by: Marcello Martina <[email protected]> * test: increased timeout to account for cache delay Signed-off-by: Marcello Martina <[email protected]> * chore: updated copyright header Signed-off-by: Marcello Martina <[email protected]> * refactor; publishAppCertificate does not throw any exception Signed-off-by: Marcello Martina <[email protected]> * feat(cloudconnection.eclipseiot.mqtt.provider): added birth message caching Signed-off-by: Marcello Martina <[email protected]> * test: add birth message caching tests Signed-off-by: Marcello Martina <[email protected]> * test: added missing test annotations Signed-off-by: Marcello Martina <[email protected]> * refactor: changed variable name to not have the same name as field Signed-off-by: Marcello Martina <[email protected]> --------- Signed-off-by: Marcello Martina <[email protected]>
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR caches the BIRTH and APP messages for 30 seconds before sending, resetting the timer when new BIRTH messages arrive. On new connections or on disconnect, the BIRTH messages are always sent immediately.
APP messages are guaranteed to be always sent only if the CC is connected; this means after the first connection BIRTH.
It is sufficient to send only the last APP/BIRTH message; the payload is not incremental and contains all the metrics available at that moment (hence the last message contains the most updated system picture).
The changes are made for
core.cloudand reflected into thecloudconnection.eclipseiot.mqtt.cloudpackage.