feat(core.cloud): publish BIRTH on EventAdmin install/uninstall events #4835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
|
@GregoryIvo can you please review? |
|
Duplication and low coverage are due to the porting of changes to the |
.../eclipse/kura/internal/cloudconnection/eclipseiot/mqtt/cloud/CloudConnectionManagerImpl.java
Show resolved
Hide resolved
salvatore-coppola
approved these changes
Sep 8, 2023
Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
pierantoniomerlino
pushed a commit
that referenced
this pull request
Sep 26, 2023
#4835) * feat(core.cloud): publish BIRTH on EventAdmin install/uninstall events Signed-off-by: Marcello Martina <[email protected]> * feat(cloudconnection.eclipseiot.mqtt.cloud): mirrored changes of d17e501 Signed-off-by: Marcello Martina <[email protected]> * style: corrected log messages Signed-off-by: Marcello Martina <[email protected]> * refactor: added return to avoid useless if evaluation Signed-off-by: Marcello Martina <[email protected]> * refactor: removed unecessary return Signed-off-by: Marcello Martina <[email protected]> --------- Signed-off-by: Marcello Martina <[email protected]>
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the standard
CloudServices to publish a BIRTH certificate message on OSGi's EventAdmin install/uninstall events.Related Issue: N/A.
Description of the solution adopted: N/A.
Screenshots: N/A.
Manual Tests: N/A.
Any side note on the changes made: N/A.