Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Return placeholder instead of encrypted passwords in REST APIs #4893

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: Return placeholder instead of encrypted passwords in REST APIs #4893

merged 1 commit into from
Oct 12, 2023

Conversation

nicolatimeus
Copy link
Contributor

Note: We are using the Conventional Commits convention for our pull request titles. Please take a look at the PR title format document for the supported types and scopes.

Brief description of the PR. [e.g. Added null check on object to avoid NullPointerException]

Changes the following rest endpoints that currently return encrypted configuration passwords to return the "placeholder" string instead:

  • CONF-V2/configurableComponents/configurations
  • CONF-V2/configurableComponents/configurations/byPid
  • WIRE-V1/configs/byPid

@MMaiero MMaiero requested a review from mattdibi October 12, 2023 13:22
mattdibi
mattdibi approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@mattdibi mattdibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested on RPi with

curl -X GET -k -u $USER:$PASSWORD https://$ADDRESS/services/configuration/v2/configurableComponents/configurations -v
... "keystore.password":{"value":"placeholder","type":"PASSWORD"} ...

@mattdibi mattdibi merged commit 058cfe2 into eclipse-kura:develop Oct 12, 2023
pierantoniomerlino pushed a commit that referenced this pull request Oct 13, 2023
@nicolatimeus @pierantoniomerlino
fix: Return placeholder instead of encrypted passwords in REST APIs (#…
8d75084 
…4893)

fix: Return placeholder instead of encrypted passwords in web ui

Signed-off-by: Nicola Timeus <[email protected]>
pierantoniomerlino pushed a commit that referenced this pull request Oct 20, 2023
@nicolatimeus @pierantoniomerlino
fix: Return placeholder instead of encrypted passwords in REST APIs (#…
ce3b698 
…4893)

fix: Return placeholder instead of encrypted passwords in web ui

Signed-off-by: Nicola Timeus <[email protected]>
This was referenced Nov 23, 2023
Closed
Merged
@nicolatimeus nicolatimeus deleted the fix_conf-v2-placeholder branch March 22, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdibi mattdibi mattdibi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolatimeus @mattdibi