Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Session REST API improvements #4947

Merged

Conversation

nicolatimeus
Copy link
Contributor

Note: We are using the Conventional Commits convention for our pull request titles. Please take a look at the PR title format document for the supported types and scopes.

Brief description of the PR. [e.g. Added null check on object to avoid NullPointerException]

  • Password strength validation is now performed on password change
  • Login banner content is now returned in authentication response
  • Added new resource to get information about current identity
  • Added new resource to get information about enabled auth methods

@@ -21,8 +21,10 @@ Import-Package: com.eclipsesource.jaxrs.provider.security;version="2.2.0",
org.eclipse.kura.request.handler.jaxrs;version="[1.0,2.0)",
org.eclipse.kura.util.configuration;version="[1.0,2.0)",
org.eclipse.kura.util.useradmin;version="[1.0,2.0)",
org.eclipse.kura.util.validation;version="1.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Range here?

@@ -0,0 +1,38 @@
package org.eclipse.kura.internal.rest.auth.dto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright header missing

Copy link
Contributor

@salvatore-coppola salvatore-coppola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MMaiero MMaiero merged commit 087b214 into eclipse-kura:develop Nov 6, 2023
github-actions bot pushed a commit that referenced this pull request Nov 6, 2023
* feat: Session REST API improvements

Signed-off-by: Nicola Timeus <[email protected]>

* Return all certificate auth ports

Signed-off-by: Nicola Timeus <[email protected]>

* Addressed comments

---------

Signed-off-by: Nicola Timeus <[email protected]>
(cherry picked from commit 087b214)
MMaiero pushed a commit that referenced this pull request Nov 7, 2023
feat: Session REST API improvements (#4947)

* feat: Session REST API improvements

Signed-off-by: Nicola Timeus <[email protected]>

* Return all certificate auth ports

Signed-off-by: Nicola Timeus <[email protected]>

* Addressed comments

---------

Signed-off-by: Nicola Timeus <[email protected]>
(cherry picked from commit 087b214)

Co-authored-by: nicolatimeus <[email protected]>
@nicolatimeus nicolatimeus deleted the enh_session-rest-improvements branch March 22, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants