-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Session REST API improvements #4947
feat: Session REST API improvements #4947
Conversation
Signed-off-by: Nicola Timeus <[email protected]>
Signed-off-by: Nicola Timeus <[email protected]>
@@ -21,8 +21,10 @@ Import-Package: com.eclipsesource.jaxrs.provider.security;version="2.2.0", | |||
org.eclipse.kura.request.handler.jaxrs;version="[1.0,2.0)", | |||
org.eclipse.kura.util.configuration;version="[1.0,2.0)", | |||
org.eclipse.kura.util.useradmin;version="[1.0,2.0)", | |||
org.eclipse.kura.util.validation;version="1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Range here?
@@ -0,0 +1,38 @@ | |||
package org.eclipse.kura.internal.rest.auth.dto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright header missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: Session REST API improvements Signed-off-by: Nicola Timeus <[email protected]> * Return all certificate auth ports Signed-off-by: Nicola Timeus <[email protected]> * Addressed comments --------- Signed-off-by: Nicola Timeus <[email protected]> (cherry picked from commit 087b214)
feat: Session REST API improvements (#4947) * feat: Session REST API improvements Signed-off-by: Nicola Timeus <[email protected]> * Return all certificate auth ports Signed-off-by: Nicola Timeus <[email protected]> * Addressed comments --------- Signed-off-by: Nicola Timeus <[email protected]> (cherry picked from commit 087b214) Co-authored-by: nicolatimeus <[email protected]>
Brief description of the PR. [e.g. Added
null
check onobject
to avoidNullPointerException
]