Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sparkplug): added SSL support, fixed some issues #5111

Merged

Conversation

marcellorinaldo
Copy link
Contributor

@marcellorinaldo marcellorinaldo commented Feb 1, 2024

This PR adds support for SSL connections towards the broker using Kura's SslManagerService. This PR addresses also some minor bugfixes (see Any side note on the changes made section).

Related Issue: Documentation PR #5112.

Description of the solution adopted: N/A.

Screenshots: N/A.

Manual Tests: N/A.

Any side note on the changes made:

  • Fixed Password field parsing
  • Fixed bdSeq not starting at 0 on BIRTH, reset bdSeq to 0 on failing connection attempt (as per Sparkplug specification).

Copy link
Contributor

@salvatore-coppola salvatore-coppola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little enchancement in one test

Signed-off-by: Marcello Martina <[email protected]>
@marcellorinaldo marcellorinaldo merged commit 4fd0318 into eclipse-kura:develop Feb 1, 2024
4 checks passed
@marcellorinaldo marcellorinaldo deleted the sparkplug-ssl-transport branch February 1, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants