feat(web2): separation between wlan channel configuration and status #5140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SimoneFiorani <[email protected]>
marcellorinaldo
requested changes
Feb 19, 2024
| } | ||
| if (TabWirelessUi.this.channelList.getItemCount() != 0) { | ||
| selectedChannelValue = this.channelList.getSelectedIndex(); | ||
| this.channelList.clear(); |
There was a problem hiding this comment.
It is best to clear outside this if, otherwise you will end up duplicate elements when changing radio mode.
|
|
||
| if (logger.isDebugEnabled()) { | ||
| Optional<WifiAccessPoint> activeAP = wifiInterfaceInfo.getActiveWifiAccessPoint(); | ||
| activeAP.ifPresent(accessPoint -> logger.debug("Wifi Interface Info: {}", |
There was a problem hiding this comment.
Maybe add a more meaningful message, like WiFi current channel status info: {}, or just remove the logging
| List<Integer> activeChannel = gwtConfig.getChannels(); | ||
| if (activeChannel != null && activeChannel.size() == 1) { | ||
| channelsBuilder.setActiveChannel(activeChannel.get(0)); | ||
| Optional<WifiAccessPoint> activeAP = wifiInterfaceInfo.getActiveWifiAccessPoint(); |
There was a problem hiding this comment.
Can this be put in common with the method above setWifiMasterStateProperties ?
| @@ -239,6 +239,14 @@ public void setHwRssi(String rssi) { | |||
| set("hwRssi", rssi); | |||
| } | |||
|
|
|||
| public String getHwWlanChannel() { | |||
There was a problem hiding this comment.
I would use a more menaningful name, like currentHwWifiChannel
| @@ -562,6 +562,7 @@ netHwRadio=Radio | |||
| netHwBand=Frequency Band | |||
| netHwLAC=LAC | |||
| netHwCI=CI | |||
| netHwWlanChannel=WLAN Channel | |||
There was a problem hiding this comment.
As in comment above, I would use a more menaningful name. Remember to update also the japanese version (just use google translate, I will ask for review later).
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
marcellorinaldo
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the separation between the WLAN Channel configuraion and status: the Wireless tab will now always show the selected option in the WLAN channles list box, while in the Hardware tab e new entry
WLAN Channelwas added, showing which is the used channel by the interface.Related Issue:
Description of the solution adopted:
Screenshots:
Manual Tests:
Any side note on the changes made: