fix: Fixed unnecessary column type changes in H2DbWireRecordStoreImpl #5157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicola Timeus <[email protected]>
marcellorinaldo
approved these changes
Feb 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
…#5157) fix: Fixed unnecessary column type changes in H2DbWireRecordStore Signed-off-by: Nicola Timeus <[email protected]> (cherry picked from commit 9d11914)
MMaiero
added a commit
that referenced
this pull request
Feb 29, 2024
… [backport release-5.4.0] (#5158) * fix: Fixed unnecessary column type changes in H2DbWireRecordStoreImpl (#5157) fix: Fixed unnecessary column type changes in H2DbWireRecordStore Signed-off-by: Nicola Timeus <[email protected]> (cherry picked from commit 9d11914) * ore: Updated distrib reference to new core bundle Signed-off-by: MMaiero <[email protected]> --------- Signed-off-by: MMaiero <[email protected]> Co-authored-by: nicolatimeus <[email protected]> Co-authored-by: MMaiero <[email protected]>
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the PR. [e.g. Added
nullcheck onobjectto avoidNullPointerException]Fixes issue that causes H2DbWireRecordStore to incorrectly change the column type and drop existing values when a new TypedValue of one of the following types is inserted:
FLOATDOUBLESTRINGBYTE_ARRAY