Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GWT servlet review #5190

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix: GWT servlet review #5190

merged 1 commit into from
Mar 26, 2024

Conversation

nicolatimeus
Copy link
Contributor

Note: We are using the Conventional Commits convention for our pull request titles. Please take a look at the PR title format document for the supported types and scopes.

Brief description of the PR. [e.g. Added null check on object to avoid NullPointerException]

Reviewed and improved legacy GWT servlet code

Signed-off-by: Nicola Timeus <[email protected]>
@nicolatimeus nicolatimeus requested a review from MMaiero March 25, 2024 16:21
@MMaiero
Copy link
Contributor

MMaiero commented Mar 26, 2024

Forcing merge.
The build succeeds locally but we are facing an issue in the CI connection to Sonar. An issue has been raised few weeks ago to the Eclipse Team: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4422

@MMaiero MMaiero merged commit 3e47263 into develop Mar 26, 2024
5 of 6 checks passed
@MMaiero MMaiero deleted the fix_servlet-review branch March 26, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants